Skip to content

Commit 4216ad5

Browse files
urmahpurfeex
andauthored
Apply suggestions from code review
Co-authored-by: Felix Exner <[email protected]>
1 parent 28d3d4c commit 4216ad5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

include/ur_client_library/control/script_command_interface.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,12 @@ class ScriptCommandInterface : public ReverseInterface
151151
* \brief Set friction compensation for the torque_command. If true the torque command will compensate for friction,
152152
* if false it will not.
153153
*
154-
* \param friction_compesation Will set a friction_compensation variable in urscript, which will be used when calling
154+
* \param friction_compensation_enabled Will set a friction_compensation variable in urscript, which will be used when calling
155155
* torque_command
156156
*
157157
* \returns True, if the write was performed successfully, false otherwise.
158158
*/
159-
bool setFrictionCompensation(const bool friction_compensation);
159+
bool setFrictionCompensation(const bool friction_compensation_enabled);
160160

161161
/*!
162162
* \brief Returns whether a client/robot is connected to this server.

include/ur_client_library/ur/ur_driver.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -718,12 +718,12 @@ class UrDriver
718718
* \brief Set friction compensation for the torque_command. If true the torque command will compensate for friction,
719719
* if false it will not.
720720
*
721-
* \param friction_compesation Will set a friction_compensation variable in urscript, which will be used when calling
721+
* \param friction_compensation_enabled Will set a friction_compensation variable in urscript, which will be used when calling
722722
* torque_command
723723
*
724724
* \returns True, if the write was performed successfully, false otherwise.
725725
*/
726-
bool setFrictionCompensation(const bool friction_compensation);
726+
bool setFrictionCompensation(const bool friction_compensation_enabled);
727727

728728
/*!
729729
* \brief Write a keepalive signal only.

src/control/script_command_interface.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ bool ScriptCommandInterface::endToolContact()
222222
return server_.write(client_fd_, buffer, sizeof(buffer), written);
223223
}
224224

225-
bool ScriptCommandInterface::setFrictionCompensation(const bool friction_compensation)
225+
bool ScriptCommandInterface::setFrictionCompensation(const bool friction_compensation_enabled)
226226
{
227227
const int message_length = 2;
228228
uint8_t buffer[sizeof(int32_t) * MAX_MESSAGE_LENGTH];
@@ -231,7 +231,7 @@ bool ScriptCommandInterface::setFrictionCompensation(const bool friction_compens
231231
int32_t val = htobe32(toUnderlying(ScriptCommand::SET_FRICTION_COMPENSATION));
232232
b_pos += append(b_pos, val);
233233

234-
val = htobe32(friction_compensation);
234+
val = htobe32(friction_compensation_enabled);
235235
b_pos += append(b_pos, val);
236236

237237
// writing zeros to allow usage with other script commands

0 commit comments

Comments
 (0)