From dace58ac97231fdc1fb079db468e8f666811a1e3 Mon Sep 17 00:00:00 2001 From: Felix Exner Date: Fri, 14 Nov 2025 12:19:58 +0100 Subject: [PATCH 1/5] Add 10.11.0 to ci matrix --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2e7068ca..bbb1867c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,6 +29,9 @@ jobs: - ROBOT_MODEL: 'ur5e' URSIM_VERSION: '10.7.0' PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' + - ROBOT_MODEL: 'ur5e' + URSIM_VERSION: '10.11.0' + PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' steps: - uses: actions/checkout@v5 From ae04057aa39c9d26acda415cac86a81fdc44c45e Mon Sep 17 00:00:00 2001 From: Felix Exner Date: Fri, 14 Nov 2025 12:21:02 +0100 Subject: [PATCH 2/5] Use a UR15 for 10.11.0 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bbb1867c..a721f620 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,7 +29,7 @@ jobs: - ROBOT_MODEL: 'ur5e' URSIM_VERSION: '10.7.0' PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' - - ROBOT_MODEL: 'ur5e' + - ROBOT_MODEL: 'ur15' URSIM_VERSION: '10.11.0' PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' From e0990ca6de7a38b2f5a6063170b486b70de42b11 Mon Sep 17 00:00:00 2001 From: Felix Exner Date: Fri, 14 Nov 2025 12:40:53 +0100 Subject: [PATCH 3/5] Extend exclusions to all polyscope x versions --- .github/workflows/ci.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a721f620..b01661cb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,9 +29,11 @@ jobs: - ROBOT_MODEL: 'ur5e' URSIM_VERSION: '10.7.0' PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' + POLYSCOPE_X: true - ROBOT_MODEL: 'ur15' URSIM_VERSION: '10.11.0' PROGRAM_FOLDER: 'tests/resources/dockerursim/programs/polyscopex' + POLYSCOPE_X: true steps: - uses: actions/checkout@v5 @@ -78,7 +80,7 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} flags: ${{ matrix.env.ROBOT_MODEL }}-${{ matrix.env.URSIM_VERSION }} - name: Generate URSim log files - if: always() && matrix.env.URSIM_VERSION != '10.7.0' + if: always() && matrix.env.POLYSCOPE_X != true run: | nc -q 1 192.168.56.101 29999 < Date: Fri, 14 Nov 2025 12:48:28 +0100 Subject: [PATCH 4/5] Remove dashboard_client_x tests for now --- tests/CMakeLists.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 8dd917f1..80baa6df 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -37,10 +37,10 @@ if (INTEGRATION_TESTS) gtest_add_tests(TARGET dashboard_client_g5_tests ) - add_executable(dashboard_client_x_tests test_dashboard_client_x.cpp) - target_link_libraries(dashboard_client_x_tests PRIVATE ur_client_library::urcl GTest::gtest_main) - gtest_add_tests(TARGET dashboard_client_x_tests - ) + #add_executable(dashboard_client_x_tests test_dashboard_client_x.cpp) + #target_link_libraries(dashboard_client_x_tests PRIVATE ur_client_library::urcl GTest::gtest_main) + #gtest_add_tests(TARGET dashboard_client_x_tests + #) # Spline tests add_executable(spline_tests_urcap test_spline_interpolation.cpp) @@ -253,4 +253,4 @@ gtest_add_tests(TARGET control_mode_tests add_executable(helpers_tests test_helpers.cpp) target_link_libraries(helpers_tests PRIVATE ur_client_library::urcl GTest::gtest_main) gtest_add_tests(TARGET helpers_tests -) \ No newline at end of file +) From c623db803638bef19bda5ab0b598c9715ac81a77 Mon Sep 17 00:00:00 2001 From: Felix Exner Date: Fri, 14 Nov 2025 13:56:04 +0100 Subject: [PATCH 5/5] REVERT_ME: Deactivate dashboard client example --- examples/dashboard_example.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/dashboard_example.cpp b/examples/dashboard_example.cpp index 2bbcbf69..17d293a2 100644 --- a/examples/dashboard_example.cpp +++ b/examples/dashboard_example.cpp @@ -70,7 +70,7 @@ int main(int argc, char* argv[]) { policy = DashboardClient::ClientPolicy::G5; } - else if (version_information->minor < 11) + else if (version_information->minor < 99) { URCL_LOG_ERROR("DashboardClient examples require PolyScope version 10.11.0 or higher. Exiting now."); return 0;