From c3cfbcf05c15e932b1fd0c0f4ed850d5cf50f51d Mon Sep 17 00:00:00 2001
From: Felix Exner <feex@universal-robots.com>
Date: Tue, 14 Jan 2025 13:25:13 +0000
Subject: [PATCH 1/4] Update to new realtime_tools header extension

---
 .../include/ur_controllers/force_mode_controller.hpp         | 2 +-
 .../ur_controllers/passthrough_trajectory_controller.hpp     | 5 ++---
 ur_controllers/src/ur_configuration_controller.cpp           | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/ur_controllers/include/ur_controllers/force_mode_controller.hpp b/ur_controllers/include/ur_controllers/force_mode_controller.hpp
index 9ae45a04b..f4284ca9d 100644
--- a/ur_controllers/include/ur_controllers/force_mode_controller.hpp
+++ b/ur_controllers/include/ur_controllers/force_mode_controller.hpp
@@ -37,12 +37,12 @@
 #pragma once
 #include <tf2_ros/buffer.h>
 #include <tf2_ros/transform_listener.h>
-#include <realtime_tools/realtime_buffer.h>
 #include <array>
 #include <memory>
 
 #include <controller_interface/controller_interface.hpp>
 #include <geometry_msgs/msg/pose_stamped.hpp>
+#include <realtime_tools/realtime_buffer.hpp>
 #include <rclcpp/rclcpp.hpp>
 #include <std_srvs/srv/trigger.hpp>
 #include <ur_msgs/srv/set_force_mode.hpp>
diff --git a/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp b/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
index a3c91d10f..617f1457c 100644
--- a/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
+++ b/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
@@ -43,9 +43,6 @@
 
 #include <stdint.h>
 
-#include <realtime_tools/realtime_buffer.h>
-#include <realtime_tools/realtime_server_goal_handle.h>
-
 #include <functional>
 #include <limits>
 #include <memory>
@@ -54,6 +51,8 @@
 #include <vector>
 
 #include <controller_interface/controller_interface.hpp>
+#include <realtime_tools/realtime_buffer.hpp>
+#include <realtime_tools/realtime_server_goal_handle.hpp>
 #include <rclcpp_action/server.hpp>
 #include <rclcpp_action/create_server.hpp>
 #include <rclcpp/rclcpp.hpp>
diff --git a/ur_controllers/src/ur_configuration_controller.cpp b/ur_controllers/src/ur_configuration_controller.cpp
index a6ec2d24b..48f909a0f 100644
--- a/ur_controllers/src/ur_configuration_controller.cpp
+++ b/ur_controllers/src/ur_configuration_controller.cpp
@@ -39,7 +39,7 @@
 //----------------------------------------------------------------------
 
 #include <ur_controllers/ur_configuration_controller.hpp>
-#include <realtime_tools/realtime_box.h>
+#include <realtime_tools/realtime_box.hpp>
 namespace ur_controllers
 {
 

From bdb91950549b2c721a7e2e52e89186cd24508601 Mon Sep 17 00:00:00 2001
From: Felix Exner <feex@universal-robots.com>
Date: Tue, 14 Jan 2025 13:26:52 +0000
Subject: [PATCH 2/4] Update pin validation to avoid compiler warning

---
 ur_controllers/src/gpio_controller.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ur_controllers/src/gpio_controller.cpp b/ur_controllers/src/gpio_controller.cpp
index 188542d0e..3fadbd3db 100644
--- a/ur_controllers/src/gpio_controller.cpp
+++ b/ur_controllers/src/gpio_controller.cpp
@@ -407,7 +407,7 @@ bool GPIOController::setAnalogOutput(ur_msgs::srv::SetAnalogOutput::Request::Sha
       return false;
   }
 
-  if (req->data.pin < 0 || req->data.pin > 1) {
+  if (!(req->data.pin == 0 || req->data.pin == 1)) {
     RCLCPP_ERROR(get_node()->get_logger(), "Invalid pin selected. Only pins 0 and 1 are allowed.");
     resp->success = false;
     return false;

From 79905bbe46a2167a3210e93e3a19f7c97731d644 Mon Sep 17 00:00:00 2001
From: Felix Exner <feex@universal-robots.com>
Date: Wed, 15 Jan 2025 10:15:12 +0000
Subject: [PATCH 3/4] Use new include path for generated parameter headers

This got updated in generate_parameters_library.
---
 ur_controllers/include/ur_controllers/force_mode_controller.hpp | 2 +-
 .../include/ur_controllers/freedrive_mode_controller.hpp        | 2 +-
 ur_controllers/include/ur_controllers/gpio_controller.hpp       | 2 +-
 .../ur_controllers/passthrough_trajectory_controller.hpp        | 2 +-
 .../ur_controllers/scaled_joint_trajectory_controller.hpp       | 2 +-
 .../include/ur_controllers/speed_scaling_state_broadcaster.hpp  | 2 +-
 .../include/ur_controllers/ur_configuration_controller.hpp      | 2 +-
 ur_controllers/package.xml                                      | 1 +
 8 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/ur_controllers/include/ur_controllers/force_mode_controller.hpp b/ur_controllers/include/ur_controllers/force_mode_controller.hpp
index f4284ca9d..5ce586f56 100644
--- a/ur_controllers/include/ur_controllers/force_mode_controller.hpp
+++ b/ur_controllers/include/ur_controllers/force_mode_controller.hpp
@@ -47,7 +47,7 @@
 #include <std_srvs/srv/trigger.hpp>
 #include <ur_msgs/srv/set_force_mode.hpp>
 
-#include "force_mode_controller_parameters.hpp"
+#include "ur_controllers/force_mode_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/freedrive_mode_controller.hpp b/ur_controllers/include/ur_controllers/freedrive_mode_controller.hpp
index 04e90805e..3b01e358b 100644
--- a/ur_controllers/include/ur_controllers/freedrive_mode_controller.hpp
+++ b/ur_controllers/include/ur_controllers/freedrive_mode_controller.hpp
@@ -53,7 +53,7 @@
 #include <rclcpp/duration.hpp>
 #include "std_msgs/msg/bool.hpp"
 
-#include "freedrive_mode_controller_parameters.hpp"
+#include "ur_controllers/freedrive_mode_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/gpio_controller.hpp b/ur_controllers/include/ur_controllers/gpio_controller.hpp
index b06b5139a..502254a9a 100644
--- a/ur_controllers/include/ur_controllers/gpio_controller.hpp
+++ b/ur_controllers/include/ur_controllers/gpio_controller.hpp
@@ -57,7 +57,7 @@
 #include "rclcpp/time.hpp"
 #include "rclcpp/duration.hpp"
 #include "std_msgs/msg/bool.hpp"
-#include "gpio_controller_parameters.hpp"
+#include "ur_controllers/gpio_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp b/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
index 617f1457c..3d9c785be 100644
--- a/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
+++ b/ur_controllers/include/ur_controllers/passthrough_trajectory_controller.hpp
@@ -64,7 +64,7 @@
 #include <trajectory_msgs/msg/joint_trajectory.hpp>
 #include <control_msgs/action/follow_joint_trajectory.hpp>
 
-#include "passthrough_trajectory_controller_parameters.hpp"
+#include "ur_controllers/passthrough_trajectory_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/scaled_joint_trajectory_controller.hpp b/ur_controllers/include/ur_controllers/scaled_joint_trajectory_controller.hpp
index 58bd12426..7ec1814f1 100644
--- a/ur_controllers/include/ur_controllers/scaled_joint_trajectory_controller.hpp
+++ b/ur_controllers/include/ur_controllers/scaled_joint_trajectory_controller.hpp
@@ -45,7 +45,7 @@
 #include "rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp"
 #include "rclcpp/time.hpp"
 #include "rclcpp/duration.hpp"
-#include "scaled_joint_trajectory_controller_parameters.hpp"
+#include "ur_controllers/scaled_joint_trajectory_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/speed_scaling_state_broadcaster.hpp b/ur_controllers/include/ur_controllers/speed_scaling_state_broadcaster.hpp
index 4778f7ce1..d2cf62e08 100644
--- a/ur_controllers/include/ur_controllers/speed_scaling_state_broadcaster.hpp
+++ b/ur_controllers/include/ur_controllers/speed_scaling_state_broadcaster.hpp
@@ -48,7 +48,7 @@
 #include "rclcpp/time.hpp"
 #include "rclcpp/duration.hpp"
 #include "std_msgs/msg/float64.hpp"
-#include "speed_scaling_state_broadcaster_parameters.hpp"
+#include "ur_controllers/speed_scaling_state_broadcaster_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp b/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
index 3775ee72c..75824af17 100644
--- a/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
+++ b/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
@@ -50,7 +50,7 @@
 #include <controller_interface/controller_interface.hpp>
 
 #include "ur_msgs/srv/get_robot_software_version.hpp"
-#include "ur_configuration_controller_parameters.hpp"
+#include "ur_controllers/ur_configuration_controller_parameters.hpp"
 
 namespace ur_controllers
 {
diff --git a/ur_controllers/package.xml b/ur_controllers/package.xml
index 5ffeea8bb..f6f169934 100644
--- a/ur_controllers/package.xml
+++ b/ur_controllers/package.xml
@@ -24,6 +24,7 @@
 
   <depend>angles</depend>
   <depend>controller_interface</depend>
+  <depend>generate_parameter_library</depend>
   <depend>geometry_msgs</depend>
   <depend>hardware_interface</depend>
   <depend>joint_trajectory_controller</depend>

From fbb18a44111a1a047a179e1ecd1cc5acf07b8dfb Mon Sep 17 00:00:00 2001
From: Felix Exner <feex@universal-robots.com>
Date: Thu, 16 Jan 2025 11:55:18 +0000
Subject: [PATCH 4/4] Update more headers

---
 .../include/ur_controllers/ur_configuration_controller.hpp      | 2 +-
 ur_robot_driver/src/ur_ros2_control_node.cpp                    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp b/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
index 75824af17..067742eb5 100644
--- a/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
+++ b/ur_controllers/include/ur_controllers/ur_configuration_controller.hpp
@@ -43,11 +43,11 @@
 
 // TODO(fmauch): Currently, the realtime_box_best_effort doesn't include this
 #include <functional>
-#include <realtime_tools/realtime_box_best_effort.h>  // NOLINT
 
 #include <memory>
 
 #include <controller_interface/controller_interface.hpp>
+#include <realtime_tools/realtime_box_best_effort.hpp>
 
 #include "ur_msgs/srv/get_robot_software_version.hpp"
 #include "ur_controllers/ur_configuration_controller_parameters.hpp"
diff --git a/ur_robot_driver/src/ur_ros2_control_node.cpp b/ur_robot_driver/src/ur_ros2_control_node.cpp
index 5cce2c044..0db64afef 100644
--- a/ur_robot_driver/src/ur_ros2_control_node.cpp
+++ b/ur_robot_driver/src/ur_ros2_control_node.cpp
@@ -41,7 +41,7 @@
 // ROS includes
 #include "controller_manager/controller_manager.hpp"
 #include "rclcpp/rclcpp.hpp"
-#include "realtime_tools/thread_priority.hpp"
+#include "realtime_tools/realtime_helpers.hpp"
 
 // code is inspired by
 // https://github.com/ros-controls/ros2_control/blob/master/controller_manager/src/ros2_control_node.cpp