Skip to content

Improve wording on disambiguation section #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Improve wording on disambiguation section #12

merged 2 commits into from
Apr 30, 2025

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Apr 30, 2025

No description provided.

@urfeex urfeex requested a review from michal-milkowski April 30, 2025 08:59
michal-milkowski
michal-milkowski approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@michal-milkowski michal-milkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Rune also had comment regarding note on the main page:
For the 2 links, they could be clearer:

"There is also builtin ROS 2 support for PolyScope X robots, see the PolyScope X ROS 2 documentation and / or ROS 2 integration paths for details."

Could be changed to:

"There is also builtin ROS 2 support for PolyScope X robots, see the PolyScope X ROS 2 documentation for details, or ROS 2 integration paths for an explanation of the difference from the ROS 2 driver documented here."

@urfeex
Copy link
Member Author

urfeex commented Apr 30, 2025

Looks good. Rune also had comment regarding note on the main page: For the 2 links, they could be clearer:

"There is also builtin ROS 2 support for PolyScope X robots, see the PolyScope X ROS 2 documentation and / or ROS 2 integration paths for details."

Could be changed to:

"There is also builtin ROS 2 support for PolyScope X robots, see the PolyScope X ROS 2 documentation for details, or ROS 2 integration paths for an explanation of the difference from the ROS 2 driver documented here."

Oh, my I forgot to push that file!

@urfeex urfeex merged commit 5c41999 into main Apr 30, 2025
1 check passed
@urfeex urfeex deleted the improve_wording branch April 30, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michal-milkowski michal-milkowski michal-milkowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@urfeex @michal-milkowski