Landing page #9
Merged
Landing page #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urrsk
approved these changes
Apr 16, 2025
Member
urrsk
left a comment
urrsk
left a comment
There was a problem hiding this comment.
I have some small suggestion, but beside of that, the text is good.
Though it feels like a bit wall of text, maybe it could be nice with a short introduction and maybe a bigger separation between the three sections.
(all that could be postponed to another PR)
Co-authored-by: Rune Søe-Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a landing page and a page explaining the difference to ROS 2 running on the controller and link to the polyscope-ros2 documentation.