Skip to content

Commit 8d8e909

Browse files
readme: minor clarifications in the "auto-update calibration data" faq entry (#184)
1 parent 4fae736 commit 8d8e909

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,12 @@ This is mainly because parameters are loaded onto the parameter server before an
252252

253253
The `robot_description` concept inside ROS is not designed to be changed while a system is running.
254254
Consumers of the urdf/`robot_description` (in terms of other ROS nodes) will not update the model
255-
they have been loading initially. While technically the description could be altered during runtime
256-
and any node that is started AFTER the description was updated, this would lead to an inconsistent
257-
state inside the system. In other words: It's not the driver that needs/benefits from this
258-
calibrated urdf, it's the rest of the ROS application.
255+
they have been loading initially. While technically the `robot_description` parameter could be altered during runtime
256+
and any node that is started *afterwards* would see the updated model, this would lead to an inconsistent
257+
application state (as some nodes will use the old model, while others use the updated one). In other words: It's not the driver that needs/benefits from this calibrated urdf, it's the rest of the ROS application and that will only see it *if* the calibrated version is present on the parameter server *before* nodes are started.
259258

260-
Additionally: If the calibration doesn't match the expected one, there's a reason for that and it
261-
should better be explicitly handled by a human. Having to run the calibration
259+
Additionally: If the calibration stored on the ROS side doesn't match the one of the robot controller, there's a good chance there is a reason for this and it
260+
would be better to make updating it a conscious decision by a human (as the driver would not know *when* updating the model would be convenient or safe). Having to run the calibration
262261
extraction/transformation as a separate step makes this possible and doesn't hide this step from the
263262
end user.
264263

0 commit comments

Comments
 (0)