Skip to content

Commit 9cdfa34

Browse files
author
Felix Exner
committed
reworded calibration extraction explanation
1 parent 7089657 commit 9cdfa34

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -251,13 +251,13 @@ the computations requiring the graphics card.
251251
This is mainly because parameters are loaded onto the parameter server before any nodes are started.
252252

253253
The `robot_description` concept inside ROS is not designed to be changed while a system is running.
254-
Consumers of the urdf/`robot_description` will not update the model they have been loading
255-
initially. It's not the driver that needs/benefits from this calibrated urdf, it's the rest of the
256-
ROS application.
257-
258-
Additionally: it's good to have this sort of things done in an off-line fashion, as that makes it
259-
predictable. If/when, for whatever reason, the calibration data changes, it's almost always better
260-
to have the files updated because of a conscious decision to do that, instead of automatically,
261-
invisible. Having to run the calibration extraction/transformation as a separate step makes this
262-
possible. If the calibration doesn't match the expected one, there's a reason for that and it should
263-
better be explicitly handled by a human.
254+
Consumers of the urdf/`robot_description` (in terms of other ROS nodes) will not update the model
255+
they have been loading initially. While technically the description could be altered during runtime
256+
and any node that is started AFTER the description was updated, this would lead to an inconsistent
257+
state inside the system. In other words: It's not the driver that needs/benefits from this
258+
calibrated urdf, it's the rest of the ROS application.
259+
260+
Additionally: If the calibration doesn't match the expected one, there's a reason for that and it
261+
should better be explicitly handled by a human. Having to run the calibration
262+
extraction/transformation as a separate step makes this possible and doesn't hide this step from the
263+
end user.

0 commit comments

Comments
 (0)