forked from python-acoustics/python-acoustics
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
bandpass_filter(), lowpass_filter(), etc. all use scipy.signal.butter(band="...") . However, the bandstop_filter() doesn't directly use the scipy.signal.butter(btype="bandstop") option. Instead, it manually combines a lowpass and highpass filter.
I assume this is because it was implemented before scipy had a bandstop option? Similarly, bandpass_filter() uses btype="band" rather than bandpass, which again I guess is because when it was implemented scipy only had bandpass as an option and called it just band.
We should update both of these to directly use the correct options in scipy.signal.butter().
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers