no courses found hint and fixed strict filtering not working

Author: MatiasSinisalo

src/client/V2/CourseRecommendations.tsx

@@ -2,6 +2,7 @@ import { Box, Stack } from '@mui/material'
 import { CourseRecommendation } from '../../common/types'
 import CourseRecommendationV2 from './CourseRecommendationV2'
 import { useFilterContext } from './filterContext'
+import NoRecommendationsInfo from './components/NoRecommendationsInfo'
 
 const CourseRecommendations = () => {
   const { finalRecommendedCourses } = useFilterContext()
@@ -13,6 +14,11 @@ const CourseRecommendations = () => {
   if(!recommendations || !points){
     return (<></>)
   }
+
+  if(points.length === 0) {
+    return <NoRecommendationsInfo />
+  }
+
   return (
     <Box>
       <Stack>

src/client/V2/components/NoRecommendationsInfo.tsx

@@ -0,0 +1,26 @@
+import { Box, Typography, Paper } from '@mui/material'
+
+const NoRecommendationsInfo = () => {
+  return (
+    <Paper
+      elevation={2}
+      sx={{
+        padding: 4,
+        margin: 2,
+        textAlign: 'center',
+        backgroundColor: 'background.paper',
+      }}
+    >
+      <Box>
+        <Typography variant="h6" component="h2" gutterBottom>
+          Kursseja ei löytynyt
+        </Typography>
+        <Typography variant="body1" color="textSecondary">
+          Yritä muuttaa valintojasi nähdäksesi kursseja.
+        </Typography>
+      </Box>
+    </Paper>
+  )
+}
+
+export default NoRecommendationsInfo

src/server/util/pointRecommendCourses.ts

@@ -172,7 +172,8 @@ function pointRecommendedCourses(courses: CourseRecommendation[], userCoordinate
     }
 
 
-    return {...c, points: points + bonusPoints}
+
+    return points >= 0 ? {...c, points: points + bonusPoints} : {...c, points}
   })
 
   const filtered = recommendationWithPoints.filter((r) => r.points >= 0)