depricated distance

Author: MatiasSinisalo

src/common/types.ts

@@ -45,7 +45,6 @@ export type Dimension = (typeof DIMENSIONS)[number]
 
 export type CourseRecommendation = {
   course: CourseData
-  distance: number //<--- to be depricated
   coordinates: CourseCoordinates
   points?: number
 } 
@@ -76,7 +75,6 @@ export type CourseCoordinates = {
 export type UserCoordinates = CourseCoordinates;
 
 export type CourseRecommendations = {
-  recommendations: CourseRecommendation[] //<-- to be depricated!
   pointBasedRecommendations: CourseRecommendation[]
   userCoordinates: UserCoordinates  
   answerData?: AnswerData

src/server/util/recommender.ts

@@ -238,8 +238,7 @@ async function calculateCourseCoordinates(course: CourseData, userCoordinates: U
 
 
 
-  //distance will get depricated soon
-  return { course: course, distance: 0, coordinates: courseCoordinates }
+  return { course: course, coordinates: courseCoordinates }
 }
 
 //returns a list of courseRecommendation
@@ -399,7 +398,6 @@ async function getRecommendations(userCoordinates: UserCoordinates, answerData:
 
   const allRecommendations = {
     pointBasedRecommendations: pointBasedRecommendations,
-    recommendations: [], //this will get depricated
     userCoordinates: userCoordinates,
   }
 

src/tests/pointRecommendCourses.test.ts

@@ -57,7 +57,6 @@ const createRecommendation = (
     credits: [],
     ...(overrides.course || {}),
   },
-  distance: overrides.distance ?? 0,
   coordinates: {
     date: 0,
     org: 1,