Skip to content

Commit 3ed12bc

Browse files
committed
no return in middleware
1 parent cab0aec commit 3ed12bc

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/server/routes/course.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ courseRouter.get('/:id', async (req, res) => {
168168
res.send(objectToReturn)
169169
})
170170

171-
/*
172171
const checkDiscussionAccess = async (
173172
req: express.Request,
174173
res: express.Response,
@@ -201,16 +200,15 @@ const checkDiscussionAccess = async (
201200
chatInstance.responsibilities.map((r) => r.user.id).includes(user.id)
202201

203202
if (!hasFullAccess) {
204-
return res.status(401).send('Unauthorized')
203+
res.status(401).send('Unauthorized')
204+
} else {
205+
next()
205206
}
206-
207-
return next()
208207
}
209-
*/
210208

211209
courseRouter.get(
212210
'/:id/discussions/:user_id',
213-
//checkDiscussionAccess,
211+
checkDiscussionAccess,
214212
async (req, res) => {
215213
const userId = decrypt(req.params.user_id)
216214
const { id } = req.params
@@ -225,8 +223,7 @@ courseRouter.get(
225223
}
226224
)
227225

228-
//courseRouter.get('/:id/discussers', checkDiscussionAccess, async (req, res) => {
229-
courseRouter.get('/:id/discussers', async (req, res) => {
226+
courseRouter.get('/:id/discussers', checkDiscussionAccess, async (req, res) => {
230227
const { id } = req.params
231228

232229
const discussionCounts = (await Discussion.findAll({

0 commit comments

Comments
 (0)