Skip to content

Commit c4010f0

Browse files
committed
fix sending res somehow too early
1 parent 146b8d5 commit c4010f0

File tree

4 files changed

+6
-54
lines changed

4 files changed

+6
-54
lines changed

e2e/chat.spec.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,7 @@
11
import { expect, test } from '@playwright/test'
22

3-
test.describe('Chat v2 Functionality Tests', () => {
3+
test.describe('Chat v2 Conversation tests', () => {
44
test.beforeEach(async ({ page }) => {
5-
page.on('requestfailed', (request) => {
6-
console.log('Request failed: ' + request.url() + ' ' + request.failure()?.errorText)
7-
})
8-
9-
page.on('request', (request) => {
10-
console.log('Request: ' + request.url())
11-
})
12-
13-
page.on('response', (response) => {
14-
console.log('Request finished: ' + response.url() + ' ' + response.status())
15-
})
16-
17-
page.on('console', (msg) => {
18-
console.log(`Console message: ${msg.text()}`)
19-
})
20-
21-
page.on('crash', () => {
22-
console.log('Page crashed')
23-
})
24-
25-
page.on('pageerror', (error) => {
26-
console.log('Page error: ' + error.message)
27-
})
28-
295
await page.goto('/v2')
306
// Press esc to close disclaimer modal if present
317
await page.keyboard.press('Escape')

e2e/healthcheck.spec.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,7 @@
11
import { test, expect } from '@playwright/test'
22

33
test.describe('Health Check Tests', () => {
4-
test.beforeEach(async ({ page }) => {
5-
page.on('requestfailed', (request) => {
6-
console.log('Request failed: ' + request.url() + ' ' + request.failure()?.errorText)
7-
})
8-
9-
page.on('request', (request) => {
10-
console.log('Request: ' + request.url())
11-
})
12-
13-
page.on('response', (response) => {
14-
console.log('Request finished: ' + response.url() + ' ' + response.status())
15-
})
16-
17-
page.on('console', (msg) => {
18-
console.log(`Console message: ${msg.text()}`)
19-
})
20-
21-
page.on('crash', () => {
22-
console.log('Page crashed')
23-
})
24-
25-
page.on('pageerror', (error) => {
26-
console.log('Page error: ' + error.message)
27-
})
28-
})
4+
test.beforeEach(async ({ page }) => {})
295

306
test('Application loads successfully', async ({ page }) => {
317
await page.goto('/')

playwright.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ export default defineConfig({
2020
/* Retry on CI only */
2121
retries: inCI ? 1 : 0,
2222
/* Global timeout for each test */
23-
timeout: 8_000,
23+
timeout: 9_000,
2424
expect: {
25-
timeout: inCI ? 4_000 : 2_000,
25+
timeout: inCI ? 4_500 : 2_250,
2626
},
2727
/* Opt out of parallel tests on CI. */
2828
workers: inCI ? 1 : undefined,

src/server/routes/rag/rag.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ router.get('/indices', async (req, res) => {
9292
}
9393

9494
if (!chatInstance.ragIndices?.length) {
95-
res.json([]).send()
95+
res.json([])
9696
return
9797
}
9898

@@ -101,7 +101,7 @@ router.get('/indices', async (req, res) => {
101101
}
102102
} else {
103103
if (!user.isAdmin) {
104-
res.json([]).send()
104+
res.json([])
105105
return
106106
}
107107
}

0 commit comments

Comments
 (0)