Skip to content

Commit 97804b6

Browse files
committed
[ClassStats][CoursesOfClass] Fix filter buttons not working
1 parent 6b1c3e3 commit 97804b6

File tree

1 file changed

+3
-2
lines changed
  • services/frontend/src/components/FilterView/filters/courses

1 file changed

+3
-2
lines changed

services/frontend/src/components/FilterView/filters/courses/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,14 @@ export const courseFilter = createFilter({
114114
render: CourseFilterCard,
115115

116116
selectors: {
117-
isCourseSelected: ({ courseFilters }, course) => !!courseFilters[course],
117+
// NOTE: Remember FilterType.ALL === 0 when checking if courseFilters[course] exists
118+
isCourseSelected: ({ courseFilters }, course) => Object.values(FilterType).includes(courseFilters[course]),
118119
selectedCourseName: ({ courses }, courseCodes) => courses[courseCodes[0]]?.name,
119120
},
120121

121122
actions: {
122123
toggleCourseSelection: (options, code) => {
123-
if (!options.courseFilters[code]) {
124+
if (!Object.values(FilterType).includes(options.courseFilters[code])) {
124125
options.courseFilters[code] = FilterType.ALL
125126
} else {
126127
delete options.courseFilters[code]

0 commit comments

Comments
 (0)