[Eslint] cypress lint

Author: joonas-a

cypress/e2e/Language_center.js

@@ -6,14 +6,13 @@ const hasLanded = () => {
 }
 
 const chooseSemester = (semester, fromOrTo) => {
-  cy.get(`[data-cy="semester-${fromOrTo}"]`)
-    .click()
-    .within(() => {
-      cy.get('div.visible.menu.transition').within(() => {
-        cy.contains('div.item', semester).click()
-      })
-      cy.get('div.menu.transition').should('not.have.class', 'visible')
+  cy.get(`[data-cy="semester-${fromOrTo}"]`).click()
+  cy.get(`[data-cy="semester-${fromOrTo}"]`).within(() => {
+    cy.get('div.visible.menu.transition').within(() => {
+      cy.contains('div.item', semester).click()
     })
+    cy.get('div.menu.transition').should('not.have.class', 'visible')
+  })
 }
 
 const checkNumbers = (numbers, numberOfColumns, mode) => {

cypress/e2e/Openuni.js

@@ -33,18 +33,12 @@ describe('Open uni population tests', () => {
         cy.get('[data-cy="open-uni-search-button"]').click()
         cy.contains('Insert course code(s)').siblings().get('textarea').as('textarea')
         cy.get('@textarea').type(courseCodesSet1.join('\n'))
-        cy.cs('begin-of-search')
-          .click()
-          .then(() => {
-            cy.cs('begin-of-search').clear()
-            cy.cs('begin-of-search').type('01.01.2015')
-          })
-        cy.cs('end-of-search')
-          .click()
-          .then(() => {
-            cy.cs('end-of-search').clear()
-            cy.cs('end-of-search').type('01.01.2020')
-          })
+        cy.cs('begin-of-search').click()
+        cy.cs('begin-of-search').clear()
+        cy.cs('begin-of-search').type('01.01.2015')
+        cy.cs('end-of-search').click()
+        cy.cs('end-of-search').clear()
+        cy.cs('end-of-search').type('01.01.2020')
         cy.get('button').contains('Search population').click()
         cy.contains('Beginning of the search for all fields:')
         cy.contains('01.01.2015')
@@ -86,9 +80,10 @@ describe('Open uni population tests', () => {
         cy.get('[data-cy="search-name"]').type('TEST-Avoimen-populaatio')
         cy.contains('Insert course code(s)').siblings().get('textarea').type(courseCodesSet1.join('\n'))
         cy.get('[data-cy="save-search"]').click()
-        cy.get('[data-cy="history-search"]').children().eq(0).type('TEST-Avoimen-populaatio').type('{enter}')
+        cy.get('[data-cy="history-search"]').children().eq(0).type('TEST-Avoimen-populaatio{enter}')
         cy.contains('TEST-Avoimen-populaatio')
-        cy.get('button').contains('Search population').click()
+        cy.get('button').contains('Search population').as('btn')
+        cy.get('@btn').click()
         cy.get('[data-cy="open-uni-table-div"]').should('contain.text', courseCodesSet1[0])
         cy.get('[data-cy="open-uni-table-div"]').should('contain.text', courseCodesSet1[1])
       })
@@ -105,7 +100,7 @@ describe('Open uni population tests', () => {
         cy.get('[data-cy="open-uni-table-div"]').should('contain.text', courseCodesSet1[1])
 
         cy.get('[data-cy="open-uni-search-button"]').click()
-        cy.get('[data-cy="history-search"]').children().eq(0).type('TEST-Avoimen-populaatio').type('{enter}')
+        cy.get('[data-cy="history-search"]').children().eq(0).type('TEST-Avoimen-populaatio{enter}')
         cy.contains('Insert course code(s)').siblings().get('textarea').should('contain', courseCodesSet1.join(', '))
         cy.contains('Insert course code(s)').siblings().get('textarea').type('\n')
         cy.contains('Insert course code(s)').siblings().get('textarea').type(courseCodesSet2.join('\n'))

cypress/e2e/Population_statistics.js

@@ -50,9 +50,8 @@ describe('Population statistics tests', () => {
         cy.cs('population-year-decrement').as('yearDecrement')
         cy.cs('population-year-increment').as('yearIncrement')
 
-        cy.get('@yearSelect')
-          .click()
-          .then(() => cy.contains('2018 - 2019').trigger('click', { force: true }))
+        cy.get('@yearSelect').click()
+        cy.contains('2018 - 2019').click()
         cy.get('@yearSelect').within(() => cy.contains('2018 - 2019'))
         cy.get('@yearDecrement').click()
         cy.get('@yearSelect').within(() => cy.contains('2017 - 2018'))
@@ -277,13 +276,20 @@ describe('Population statistics tests', () => {
         cy.visit(pathToMathBSc2020)
         cy.contains('Courses of class').click()
 
-        cy.cs('curriculum-picker').scrollIntoView().should('be.visible').click()
+        cy.cs('curriculum-picker').scrollIntoView()
+        cy.cs('curriculum-picker').should('be.visible')
+        cy.cs('curriculum-picker').click()
         cy.contains('2020–2023').click({ force: true })
         cy.contains('Students (27)')
-        cy.cs('toggle-group-module-DIGI-k').should('exist').scrollIntoView().should('be.visible').click({ force: true })
+        cy.cs('toggle-group-module-DIGI-k').should('exist')
+        cy.cs('toggle-group-module-DIGI-k').scrollIntoView()
+        cy.cs('toggle-group-module-DIGI-k').should('be.visible')
+        cy.cs('toggle-group-module-DIGI-k').click({ force: true })
         cy.contains('DIGI-100').should('exist')
 
-        cy.cs('curriculum-picker').scrollIntoView().should('be.visible').click()
+        cy.cs('curriculum-picker').scrollIntoView()
+        cy.cs('toggle-group-module-DIGI-k').should('be.visible')
+        cy.cs('curriculum-picker').click()
         cy.contains('2023–2026').click({ force: true })
         cy.cs('toggle-group-module-DIGI-k').should('exist')
         cy.contains('DIGI-100').should('not.exist')

cypress/plugins/index.js

@@ -15,7 +15,6 @@
 /**
  * @type {Cypress.PluginConfig}
  */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 module.exports = (on, config) => {
   // `on` is used to hook into various events Cypress emits
   // `config` is the resolved Cypress config