fix: make clippy work again on CI (#1432)

Author: sighphyre

.github/workflows/clippy.yaml

@@ -24,24 +24,18 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      security-events: write
-      actions: read
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
+
       - name: Install rust
         run: |
           rustup set auto-self-update disable
-          rustup toolchain install 1.89.0 --profile default
           rustup show
+
       - name: Rust cache
         uses: Swatinem/rust-cache@v2
-      - name: Install required cargo packages for reporting format
-        run: cargo install clippy-sarif sarif-fmt
-      - name: Run rust-clippy
-        run: |
-          cargo clippy --all-features --all-targets --message-format=json -- -D warnings | clippy-sarif | tee results.sarif | sarif-fmt
-      - name: Upload SARIF file
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: "results.sarif"
+
+      - name: Run clippy
+        run: cargo clippy --workspace --all-features --all-targets -- -D warnings

crates/enterprise/unleash-edge-delta/src/cache.rs

@@ -148,7 +148,7 @@ mod tests {
         let max_length = 2;
         let mut delta_cache = DeltaCache::new(base_event.clone(), max_length);
 
-        let initial_events = &vec![DeltaEvent::FeatureUpdated {
+        let initial_events = &[DeltaEvent::FeatureUpdated {
             event_id: 2,
             feature: ClientFeature {
                 name: "my-feature-flag".to_string(),
@@ -233,7 +233,7 @@ mod tests {
                 ..ClientFeature::default()
             },
         };
-        delta_cache.add_events(&vec![initial_feature_event.clone()]);
+        delta_cache.add_events(std::slice::from_ref(&initial_feature_event));
 
         let updated_feature_event = DeltaEvent::FeatureUpdated {
             event_id: 130,
@@ -251,7 +251,7 @@ mod tests {
                 ..ClientFeature::default()
             },
         };
-        delta_cache.add_events(&vec![updated_feature_event.clone()]);
+        delta_cache.add_events(std::slice::from_ref(&updated_feature_event));
 
         assert_eq!(delta_cache.get_events()[1], initial_feature_event);
         assert_eq!(delta_cache.get_events()[2], updated_feature_event);

crates/enterprise/unleash-edge-tracing/src/lib.rs

@@ -153,9 +153,9 @@ fn enterprise_tracing(args: &CliArgs, app_id: String) -> EdgeResult<Option<OtelH
     }
 }
 
+#[allow(unused_variables)]
 /// Instantiates exporters for traces, metrics and logs
 /// the exporter will read environment variables as specified in (Otel docs)[https://opentelemetry.io/docs/specs/otel/protocol/exporter/]
-///
 pub fn init_tracing_and_logging(args: &CliArgs, app_id: String) -> EdgeResult<Option<OtelHolder>> {
     #[cfg(feature = "enterprise")]
     {
@@ -268,7 +268,6 @@ mod tests {
         let _ = formatting_layer::<tracing_subscriber::Registry>(&args);
     }
 
-    #[cfg(feature = "enterprise")]
     #[test]
     #[cfg(feature = "enterprise")]
     fn test_resource_creation() {

crates/oss/unleash-edge-feature-filters/src/lib.rs

@@ -377,7 +377,7 @@ mod tests {
         feature_cache.insert(map_key.clone(), client_features);
 
         let features = feature_cache.get(&map_key).unwrap();
-        let filter = FeatureFilterSet::from(Box::new(|f| f.name == "feature-one".to_string()));
+        let filter = FeatureFilterSet::from(Box::new(|f| f.name == "feature-one"));
         let filtered_client_features = filter_client_features(&features, &filter);
 
         let sent_segments = filtered_client_features.segments.as_ref().unwrap();
@@ -430,7 +430,7 @@ mod tests {
         feature_cache.insert(map_key.clone(), client_features);
 
         let features = feature_cache.get(&map_key).unwrap();
-        let filter = FeatureFilterSet::from(Box::new(|f| f.name == "feature-one".to_string()));
+        let filter = FeatureFilterSet::from(Box::new(|f| f.name == "feature-one"));
         let filtered_client_features = filter_client_features(&features, &filter);
 
         assert!(filtered_client_features.segments.is_none());

crates/oss/unleash-edge-integration-tests/src/streaming_refresher.rs

@@ -94,7 +94,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Inigo Montoya".into(),
@@ -114,7 +114,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Westley".into(),
@@ -247,7 +247,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Inigo Montoya".into(),
@@ -303,7 +303,7 @@ mod tests {
         let inject_event = async move || {
             delta_cache_manager.update_cache(
                 &token.environment.clone().unwrap(),
-                &vec![DeltaEvent::FeatureUpdated {
+                &[DeltaEvent::FeatureUpdated {
                     event_id: 2,
                     feature: ClientFeature {
                         name: "Westley".into(),
@@ -409,7 +409,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Inigo Montoya".into(),
@@ -462,7 +462,7 @@ mod tests {
         let inject_event = async move || {
             delta_cache_manager.update_cache(
                 &token.environment.clone().unwrap(),
-                &vec![DeltaEvent::FeatureUpdated {
+                &[DeltaEvent::FeatureUpdated {
                     event_id: 2,
                     feature: ClientFeature {
                         name: "Westley".into(),
@@ -519,7 +519,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Inigo Montoya".into(),
@@ -580,7 +580,7 @@ mod tests {
 
             delta_cache_manager.update_cache(
                 &token.environment.clone().unwrap(),
-                &vec![DeltaEvent::FeatureUpdated {
+                &[DeltaEvent::FeatureUpdated {
                     event_id: 2,
                     feature: ClientFeature {
                         name: "Westley".into(),
@@ -644,7 +644,7 @@ mod tests {
 
         delta_cache_manager.update_cache(
             &dev_token.environment.clone().unwrap(),
-            &vec![DeltaEvent::FeatureUpdated {
+            &[DeltaEvent::FeatureUpdated {
                 event_id: 1,
                 feature: ClientFeature {
                     name: "Inigo Montoya".into(),
@@ -717,7 +717,7 @@ mod tests {
             );
             delta_cache_manager.update_cache(
                 &prod_token.environment.clone().unwrap(),
-                &vec![DeltaEvent::FeatureUpdated {
+                &[DeltaEvent::FeatureUpdated {
                     event_id: 1,
                     feature: ClientFeature {
                         name: "Inigo Montoya".into(),

crates/oss/unleash-edge-types/src/extract/host.rs

@@ -1,3 +1,4 @@
+#![allow(warnings)]
 use super::rejection::{FailedToResolveHost, HostRejection};
 use axum_core::{
     RequestPartsExt,

rust-toolchain.toml

@@ -1,2 +1,3 @@
 [toolchain]
 channel = "1.93.0"
+components = ["clippy"]