Skip to content

Commit cdb9243

Browse files
committed
Add missing await/flush in API endpoints
1 parent 5ea63ac commit cdb9243

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/modules/core/i18n/middlewares/localeMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const localeMiddleware = async (req: NextApiRequest, res: NextApiResponse
6565
localeFound = customer?.availableLanguages?.[0] || DEFAULT_LOCALE;
6666
}
6767

68-
logEvent(AMPLITUDE_EVENTS.API_LOCALE_MIDDLEWARE_INVOKED, null, {
68+
await logEvent(AMPLITUDE_EVENTS.API_LOCALE_MIDDLEWARE_INVOKED, null, {
6969
locale: localeFound,
7070
});
7171

src/pages/api/startVercelDeployment.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import dispatchWorkflowByPath from '@/modules/core/githubActions/dispatchWorkflo
88
import { createLogger } from '@/modules/core/logging/logger';
99
import { ALERT_TYPES } from '@/modules/core/sentry/config';
1010
import { configureReq } from '@/modules/core/sentry/server';
11+
import { flushSafe } from '@/modules/core/sentry/universal';
1112
import * as Sentry from '@sentry/node';
1213
import size from 'lodash.size';
1314
import {
@@ -141,6 +142,8 @@ const startVercelDeployment = async (req: EndpointRequest, res: NextApiResponse)
141142
Sentry.captureException(new Error(errorMessage));
142143
logger.error(errorMessage);
143144

145+
await flushSafe();
146+
144147
return redirect(res, redirectTo, statusCode);
145148
}
146149

@@ -159,6 +162,8 @@ const startVercelDeployment = async (req: EndpointRequest, res: NextApiResponse)
159162
Sentry.captureException(new Error(errorMessage));
160163
logger.error(errorMessage);
161164

165+
await flushSafe();
166+
162167
return redirect(res, redirectTo, statusCode);
163168
}
164169

@@ -167,6 +172,8 @@ const startVercelDeployment = async (req: EndpointRequest, res: NextApiResponse)
167172
Sentry.captureException(new Error(errorMessage));
168173
logger.error(errorMessage);
169174

175+
await flushSafe();
176+
170177
return redirect(res, redirectTo, statusCode);
171178
}
172179

@@ -179,6 +186,8 @@ const startVercelDeployment = async (req: EndpointRequest, res: NextApiResponse)
179186
Sentry.captureException(e);
180187
logger.error(e.message);
181188

189+
await flushSafe();
190+
182191
res.json({
183192
error: true,
184193
message: process.env.NEXT_PUBLIC_APP_STAGE === 'production' ? undefined : e.message,

0 commit comments

Comments
 (0)