refactor(apex): ensure unique RecordType mapping #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tRecordTypeInfosByName in GetRecordtypeInfobyObjects
…tRecordTypeInfosByName in GetRecordtypeInfobyObjects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the use of
getRecordTypeInfosByName()withgetRecordTypeInfosByDeveloperName()in theGetRecordtypeInfobyObjectsclass.The purpose of this change is to ensure that the keys of the map returned by the
Schema.DescribeSObjectResultcall are unique and stable, preventing potential key collisions when translated Record Type labels are identical.Technical context
The
getRecordTypeInfosByName()method returns aMap<String, Schema.RecordTypeInfo>whose keys are the translated labels of the Record Types. That is, the label displayed in the user interface, depending on the user’s active language.In Salesforce, different Record Types can share the same translated label. However, map keys must be unique (they behave like a Set), so if two Record Types share the same label, one of them will overwrite the other in the map, leading to inconsistent or unexpected results.
The standard
getRecordTypeInfosByDeveloperName()method solves this issue because it returns a Map<String, Schema.RecordTypeInfo> whose keys are the Developer Names (API Names) of the Record Types, which are unique per object and language-independent.This change does not alter the functional behavior of the component. It only improves code reliability in environments with translated Record Type labels.