make log file on linux auto. allow dir instead of file for log file

Author: davidnewhall

init/systemd/after-install.sh

@@ -11,14 +11,20 @@ if [ "${OS}" = "Linux" ]; then
     useradd --system --user-group --no-create-home --home-dir /tmp --shell /bin/false unpackerr
 elif [ "${OS}" = "OpenBSD" ]; then
   id unpackerr >/dev/null 2>&1  || \
-    useradd  -g =uid -d /tmp -s /bin/false unpackerr
+    useradd -g =uid -d /tmp -s /bin/false unpackerr
 elif [ "${OS}" = "FreeBSD" ]; then
   id unpackerr >/dev/null 2>&1  || \
     pw useradd unpackerr -d /tmp -w no -s /bin/false
 else
   echo "Unknown OS: ${OS}, please add system user unpackerr manually."
 fi
 
+if [ ! -d "/var/log/unpackerr" ]; then
+  mkdir /var/log/unpackerr
+  chown unpackerr: /var/log/unapckerr
+  chmod 0755 /var/log/unpackerr
+fi
+
 if [ -x "/bin/systemctl" ]; then
   # Reload and restart - this starts the application as user nobody.
   /bin/systemctl daemon-reload

init/systemd/unpackerr.service

@@ -12,13 +12,16 @@ After=network-online.target
 ExecStart=/usr/bin/unpackerr $DAEMON_OPTS
 EnvironmentFile=-/etc/default/unpackerr
 EnvironmentFile=-/etc/sysconfig/unpackerr
+Environment=UN_LOG_FILE=/var/log/unpackerr/unpackerr.log
+Environment=UN_WEBSERVER_LOG_FILE=/var/log/unpackerr/http.log
 Restart=always
 RestartSec=10
 SyslogIdentifier=unpackerr
 Type=simple
 WorkingDirectory=/tmp
 
 # These should be set correctly for your environment.
+# If you change User, fix ownership on /var/log/unpackerr too.
 UMask=0002
 User=unpackerr
 Group=unpackerr

pkg/unpackerr/logs.go

@@ -5,6 +5,7 @@ import (
 	"io"
 	"log"
 	"os"
+	"path/filepath"
 	"runtime"
 	"strconv"
 	"time"
@@ -138,10 +139,7 @@ func (u *Unpackerr) setupLogging() {
 		u.Logger.Error.SetFlags(log.Lshortfile | log.Lmicroseconds | log.Ldate)
 	}
 
-	if logFile, err := homedir.Expand(u.Config.LogFile); err == nil {
-		u.Config.LogFile = logFile
-	}
-
+	u.Config.LogFile = getLogFilePath(u.Config.LogFile, "unpackerr.log")
 	fileMode, _ := strconv.ParseUint(u.LogFileMode, bits8, base32)
 	rotate := &rotatorr.Config{
 		Filepath: u.Config.LogFile,                     // log file name.
@@ -175,6 +173,21 @@ func (u *Unpackerr) setupLogging() {
 	}
 }
 
+// getLogFilePath takes in a path and a base name. In case the path is a directory, they are joined.
+func getLogFilePath(logFile, base string) string {
+	output := logFile
+
+	if expanded, err := homedir.Expand(logFile); err == nil {
+		output = expanded
+	}
+
+	if stat, err := os.Stat(output); err != nil && stat.IsDir() {
+		output = filepath.Join(output, base)
+	}
+
+	return output
+}
+
 func (u *Unpackerr) updateLogOutput(writer io.Writer, errors io.Writer) {
 	if u.Webserver != nil && u.Webserver.LogFile != "" {
 		u.setupHTTPLogging()
@@ -193,9 +206,7 @@ func (u *Unpackerr) updateLogOutput(writer io.Writer, errors io.Writer) {
 }
 
 func (u *Unpackerr) setupHTTPLogging() {
-	if logFile, err := homedir.Expand(u.Webserver.LogFile); err == nil {
-		u.Webserver.LogFile = logFile
-	}
+	u.Webserver.LogFile = getLogFilePath(u.Webserver.LogFile, "http.log")
 
 	rotate := &rotatorr.Config{
 		Filepath: u.Webserver.LogFile,                     // log file name.