update linter

Author: davidnewhall

.github/workflows/codetests.yml

@@ -37,9 +37,9 @@ jobs:
       - name: go-generate
         run: GOOS=darwin go generate ./...
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: 'v1.62'
+          version: 'v2.0'
 
   golangci-linux:
     # description: "Runs golangci-lint on linux against linux and windows."
@@ -58,6 +58,6 @@ jobs:
       - name: go-generate
         run: GOOS=linux go generate ./...
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: 'v1.62'
+          version: 'v2.0'

.golangci.yml

@@ -1,8 +1,7 @@
+version: "2"
 linters:
-  enable-all: true
+  default: all
   disable:
-    # deprecated
-    - exportloopref
     # unused
     - exhaustruct
     - exhaustive
@@ -11,33 +10,45 @@ linters:
     - tagliatelle
     - cyclop
     - testpackage
+    #fix this
+    - staticcheck
+  settings:
+    depguard:
+      rules:
+        main:
+          files:
+            - $all
+          allow:
+            - $gostd
+            - github.com/Unpackerr/unpackerr
+            - github.com/lestrrat-go/apache-logformat
+            - github.com/gen2brain/dlgs
+            - github.com/getlantern/systray
+            - github.com/hako/durafmt
+            - github.com/mitchellh/go-homedir
+            - github.com/fsnotify/fsnotify
+            - github.com/radovskyb/watcher
+            - github.com/prometheus/client_golang/
+            - github.com/spf13/pflag
+            - github.com/julienschmidt/httprouter
+            - github.com/BurntSushi/toml
+            - golift.io
+            - golang.org/x
+            - gopkg.in/yaml.v3
+
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - std-error-handling
 
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
-
-output:
-  sort-results: true
-run:
-  timeout: 3m
-
-linters-settings:
-  depguard:
-    rules:
-      main:
-        files:
-        - $all
-        allow:
-        - $gostd
-        - github.com/Unpackerr/unpackerr
-        - github.com/lestrrat-go/apache-logformat
-        - github.com/gen2brain/dlgs
-        - github.com/getlantern/systray
-        - github.com/hako/durafmt
-        - github.com/mitchellh/go-homedir
-        - github.com/fsnotify/fsnotify
-        - github.com/radovskyb/watcher
-        - github.com/prometheus/client_golang/
-        - github.com/spf13/pflag
-        - github.com/julienschmidt/httprouter
-        - github.com/BurntSushi/toml
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+    - goimports

go.mod

@@ -1,8 +1,6 @@
 module github.com/Unpackerr/unpackerr
 
-go 1.23
-
-toolchain go1.23.4
+go 1.24
 
 require (
 	github.com/BurntSushi/toml v1.4.0

pkg/unpackerr/start_test.go

@@ -9,13 +9,9 @@ import (
 func TestDirIsEmpty(t *testing.T) {
 	t.Parallel()
 
-	emptyDir, err := os.MkdirTemp("", "gobuildtestdir")
-	if err != nil {
-		t.Fatalf("Got an error making temp folder: %v", err)
-	}
-
+	emptyDir := t.TempDir()
 	if !dirIsEmpty(emptyDir) {
-		t.Fatal("dirIsEmpty should return true on an emty folder")
+		t.Fatal("dirIsEmpty should return true on an empty folder")
 	}
 
 	f, err := os.Create(filepath.Join(emptyDir, "emptyFile"))

pkg/unpackerr/tray.go

@@ -101,26 +101,25 @@ func (u *Unpackerr) watchDebugChannels() {
 
 func (u *Unpackerr) watchGuiChannels() {
 	for {
-		//nolint:errcheck
 		select {
 		case <-u.menu["conf"].Clicked():
 			// does nothing on purpose
 		case <-u.menu["edit"].Clicked():
 			u.Printf("User Editing Config File: %s", u.Flags.ConfigFile)
-			ui.OpenFile(u.Flags.ConfigFile)
+			_ = ui.OpenFile(u.Flags.ConfigFile)
 		case <-u.menu["link"].Clicked():
 			// does nothing on purpose
 		case <-u.menu["info"].Clicked():
 			// does nothing on purpose
 		case <-u.menu["disc"].Clicked():
-			ui.OpenURL("https://golift.io/discord")
+			_ = ui.OpenURL("https://golift.io/discord")
 		case <-u.menu["gh"].Clicked():
-			ui.OpenURL("https://github.com/Unpackerr/unpackerr/")
+			_ = ui.OpenURL("https://github.com/Unpackerr/unpackerr/")
 		case <-u.menu["logs"].Clicked():
 			// does nothing on purpose
 		case <-u.menu["logs_view"].Clicked():
 			u.Printf("User Viewing Log File: %s", u.Config.LogFile)
-			ui.OpenLog(u.Config.LogFile)
+			_ = ui.OpenLog(u.Config.LogFile)
 		case <-u.menu["logs_rotate"].Clicked():
 			u.rotateLogs()
 		case <-u.menu["update"].Clicked():