Skip to content

Commit b2ff41a

Browse files
authored
⚡️ Speed up method MilvusUploadStager.parse_date_string by 432% (#592)
1 parent f396703 commit b2ff41a

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.2.17-dev1
2+
3+
* **Optimize `MilvusUploadStager.parse_date_string`**
4+
15
## 1.2.17-dev0
26

37
* **Optimize `parse_date_string` for sql connector**

unstructured_ingest/__version__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
__version__ = "1.2.17-dev0" # pragma: no cover
2-
1+
__version__ = "1.2.17-dev1" # pragma: no cover

unstructured_ingest/processes/connectors/milvus.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import json
22
from contextlib import contextmanager
33
from dataclasses import dataclass, field
4+
from datetime import datetime
45
from typing import TYPE_CHECKING, Any, Generator, Optional
56

67
from dateutil import parser
@@ -97,6 +98,13 @@ def parse_date_string(date_string: str) -> float:
9798
return timestamp
9899
except ValueError:
99100
pass
101+
102+
try:
103+
dt = datetime.fromisoformat(date_string.replace("Z", "+00:00"))
104+
return dt.timestamp()
105+
except ValueError:
106+
pass
107+
100108
return parser.parse(date_string).timestamp()
101109

102110
def conform_dict(self, element_dict: dict, file_data: FileData) -> dict:

0 commit comments

Comments
 (0)