Skip to content

Commit f4284e9

Browse files
authored
bugfix/fix sql download file data (#313)
* require source identifier content on file data, fix batch connectors * bump changelog * add utility to get either file data types from dict * create solid release * populate source identifier in mock file data * regenerate other fixtures * tidy
1 parent fcb1d30 commit f4284e9

File tree

65 files changed

+321
-142
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+321
-142
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1-
## 0.3.11-dev0
1+
## 0.3.11
22

33
### Enhancements
44

55
* **Support Databricks personal access token**
66

7+
### Fixes
8+
9+
* **Fix missing source identifiers in some downloaders**
10+
711
## 0.3.10
812

913
### Enhancements
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"identifier": "25b75f1d-a2ea-4c97-b75f-1da2eadc97f7.csv",
33
"connector_type": "astradb",
4-
"source_identifiers": null,
4+
"source_identifiers": {
5+
"filename": "25b75f1d-a2ea-4c97-b75f-1da2eadc97f7.csv",
6+
"fullpath": "25b75f1d-a2ea-4c97-b75f-1da2eadc97f7.csv",
7+
"rel_path": null
8+
},
59
"metadata": {
610
"url": null,
711
"version": null,
@@ -10,7 +14,7 @@
1014
},
1115
"date_created": null,
1216
"date_modified": null,
13-
"date_processed": "1734108082.652201",
17+
"date_processed": "1734616909.789815",
1418
"permissions_data": null,
1519
"filesize_bytes": null
1620
},
@@ -19,6 +23,6 @@
1923
"keyspace": null
2024
},
2125
"reprocess": false,
22-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-75/test_astra_search_source0/25b75f1d-a2ea-4c97-b75f-1da2eadc97f7.csv",
26+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-0/test_astra_search_source0/25b75f1d-a2ea-4c97-b75f-1da2eadc97f7.csv",
2327
"display_name": null
2428
}

test/integration/connectors/expected_results/astradb/file_data/43d02113-723f-5ec1-acbb-c8da8d3650dc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"record_locator": null,
99
"date_created": null,
1010
"date_modified": null,
11-
"date_processed": "1734108082.497229",
11+
"date_processed": "1734616909.6431518",
1212
"permissions_data": null,
1313
"filesize_bytes": null
1414
},
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"identifier": "60297eea-73d7-4fca-a97e-ea73d7cfca62.csv",
33
"connector_type": "astradb",
4-
"source_identifiers": null,
4+
"source_identifiers": {
5+
"filename": "60297eea-73d7-4fca-a97e-ea73d7cfca62.csv",
6+
"fullpath": "60297eea-73d7-4fca-a97e-ea73d7cfca62.csv",
7+
"rel_path": null
8+
},
59
"metadata": {
610
"url": null,
711
"version": null,
@@ -10,7 +14,7 @@
1014
},
1115
"date_created": null,
1216
"date_modified": null,
13-
"date_processed": "1734108082.6517608",
17+
"date_processed": "1734616909.789366",
1418
"permissions_data": null,
1519
"filesize_bytes": null
1620
},
@@ -19,6 +23,6 @@
1923
"keyspace": null
2024
},
2125
"reprocess": false,
22-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-75/test_astra_search_source0/60297eea-73d7-4fca-a97e-ea73d7cfca62.csv",
26+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-0/test_astra_search_source0/60297eea-73d7-4fca-a97e-ea73d7cfca62.csv",
2327
"display_name": null
2428
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"identifier": "641d99e3-9941-4c18-9d99-e399414c183d.csv",
33
"connector_type": "astradb",
4-
"source_identifiers": null,
4+
"source_identifiers": {
5+
"filename": "641d99e3-9941-4c18-9d99-e399414c183d.csv",
6+
"fullpath": "641d99e3-9941-4c18-9d99-e399414c183d.csv",
7+
"rel_path": null
8+
},
59
"metadata": {
610
"url": null,
711
"version": null,
@@ -10,7 +14,7 @@
1014
},
1115
"date_created": null,
1216
"date_modified": null,
13-
"date_processed": "1734108082.652407",
17+
"date_processed": "1734616909.788801",
1418
"permissions_data": null,
1519
"filesize_bytes": null
1620
},
@@ -19,6 +23,6 @@
1923
"keyspace": null
2024
},
2125
"reprocess": false,
22-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-75/test_astra_search_source0/641d99e3-9941-4c18-9d99-e399414c183d.csv",
26+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-0/test_astra_search_source0/641d99e3-9941-4c18-9d99-e399414c183d.csv",
2327
"display_name": null
2428
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"identifier": "762c0093-2277-4f3e-ac00-932277af3e0e.csv",
33
"connector_type": "astradb",
4-
"source_identifiers": null,
4+
"source_identifiers": {
5+
"filename": "762c0093-2277-4f3e-ac00-932277af3e0e.csv",
6+
"fullpath": "762c0093-2277-4f3e-ac00-932277af3e0e.csv",
7+
"rel_path": null
8+
},
59
"metadata": {
610
"url": null,
711
"version": null,
@@ -10,7 +14,7 @@
1014
},
1115
"date_created": null,
1216
"date_modified": null,
13-
"date_processed": "1734108082.651469",
17+
"date_processed": "1734616909.789599",
1418
"permissions_data": null,
1519
"filesize_bytes": null
1620
},
@@ -19,6 +23,6 @@
1923
"keyspace": null
2024
},
2125
"reprocess": false,
22-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-75/test_astra_search_source0/762c0093-2277-4f3e-ac00-932277af3e0e.csv",
26+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-0/test_astra_search_source0/762c0093-2277-4f3e-ac00-932277af3e0e.csv",
2327
"display_name": null
2428
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"identifier": "ae40df94-0b3a-4f89-80df-940b3a6f8966.csv",
33
"connector_type": "astradb",
4-
"source_identifiers": null,
4+
"source_identifiers": {
5+
"filename": "ae40df94-0b3a-4f89-80df-940b3a6f8966.csv",
6+
"fullpath": "ae40df94-0b3a-4f89-80df-940b3a6f8966.csv",
7+
"rel_path": null
8+
},
59
"metadata": {
610
"url": null,
711
"version": null,
@@ -10,7 +14,7 @@
1014
},
1115
"date_created": null,
1216
"date_modified": null,
13-
"date_processed": "1734108082.651985",
17+
"date_processed": "1734616909.789103",
1418
"permissions_data": null,
1519
"filesize_bytes": null
1620
},
@@ -19,6 +23,6 @@
1923
"keyspace": null
2024
},
2125
"reprocess": false,
22-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-75/test_astra_search_source0/ae40df94-0b3a-4f89-80df-940b3a6f8966.csv",
26+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/pytest-of-romanisecke/pytest-0/test_astra_search_source0/ae40df94-0b3a-4f89-80df-940b3a6f8966.csv",
2327
"display_name": null
2428
}

test/integration/connectors/expected_results/mongodb/file_data/172fdbf9-275b-5e38-82e6-4ec730d42460.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"date_created": null,
1313
"date_modified": null,
14-
"date_processed": "1734380792.896338",
14+
"date_processed": "1734616944.92011",
1515
"permissions_data": null,
1616
"filesize_bytes": null
1717
},

test/integration/connectors/expected_results/mongodb/file_data/659daefa21dd8c9054b084b6.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"source_identifiers": {
55
"filename": "659daefa21dd8c9054b084b6.txt",
66
"fullpath": "659daefa21dd8c9054b084b6.txt",
7-
"rel_path": "659daefa21dd8c9054b084b6.txt"
7+
"rel_path": null
88
},
99
"metadata": {
1010
"url": null,
@@ -16,7 +16,7 @@
1616
},
1717
"date_created": "2024-01-09T20:39:22+00:00",
1818
"date_modified": null,
19-
"date_processed": "1734380792.896338",
19+
"date_processed": "1734616944.92011",
2020
"permissions_data": null,
2121
"filesize_bytes": null
2222
},
@@ -25,6 +25,6 @@
2525
"collection": "sample-mongodb-data"
2626
},
2727
"reprocess": false,
28-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/tmpyfmsos4r/659daefa21dd8c9054b084b6.txt",
28+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/tmpc2l6l7w3/659daefa21dd8c9054b084b6.txt",
2929
"display_name": null
3030
}

test/integration/connectors/expected_results/mongodb/file_data/659daefa21dd8c9054b084b7.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"source_identifiers": {
55
"filename": "659daefa21dd8c9054b084b7.txt",
66
"fullpath": "659daefa21dd8c9054b084b7.txt",
7-
"rel_path": "659daefa21dd8c9054b084b7.txt"
7+
"rel_path": null
88
},
99
"metadata": {
1010
"url": null,
@@ -16,7 +16,7 @@
1616
},
1717
"date_created": "2024-01-09T20:39:22+00:00",
1818
"date_modified": null,
19-
"date_processed": "1734380792.896338",
19+
"date_processed": "1734616944.92011",
2020
"permissions_data": null,
2121
"filesize_bytes": null
2222
},
@@ -25,6 +25,6 @@
2525
"collection": "sample-mongodb-data"
2626
},
2727
"reprocess": false,
28-
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/tmpyfmsos4r/659daefa21dd8c9054b084b7.txt",
28+
"local_download_path": "/private/var/folders/n8/rps3wl195pj4p_0vyxqj5jrw0000gn/T/tmpc2l6l7w3/659daefa21dd8c9054b084b7.txt",
2929
"display_name": null
3030
}

0 commit comments

Comments
 (0)