chore [Nex-57]: remove calling wrap_error for HTTPException
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuming-long
changed the title
wrap_error for HTTPExceptionwrap_error for HTTPException
ds-filipknefel
approved these changes
Jun 30, 2025
ds-filipknefel
left a comment
ds-filipknefel
left a comment
There was a problem hiding this comment.
I'll close mine and we can merge this, let's handle the HTTPExeption in wrap function though it can lead to unexpected behavior if someone passes is as argument and we don't really indicate they shouldn't.
yuming-long
deleted the
yuming/nex-57-readtimeout-did-not-raised-correctly-for-partitioner-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not add each case for different HTTP status code -> should just raise one when we see one
wrap_errorshould only be called forException