Skip to content

Commit 9507818

Browse files
committed
use long for time values
1 parent c604afa commit 9507818

File tree

6 files changed

+17
-15
lines changed

6 files changed

+17
-15
lines changed

app/src/main/java/com/uravgcode/chooser/chooser/presentation/Chooser.kt

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class Chooser(
5454

5555
private val screenHeight = resources.displayMetrics.heightPixels
5656
private val scale = resources.displayMetrics.density
57-
private var lastTime = System.currentTimeMillis()
57+
private var previousTime = System.currentTimeMillis()
5858

5959
private val handler = Handler(Looper.getMainLooper())
6060

@@ -78,8 +78,9 @@ class Chooser(
7878
}
7979

8080
override fun onDraw(canvas: Canvas) {
81-
val deltaTime = (System.currentTimeMillis() - lastTime).toInt()
82-
lastTime = System.currentTimeMillis()
81+
val currentTime = System.currentTimeMillis()
82+
val deltaTime = currentTime - previousTime
83+
previousTime = currentTime
8384

8485
circles.update(deltaTime)
8586

@@ -175,9 +176,9 @@ class Chooser(
175176
}, 150)
176177
},
177178
when (mode) {
178-
Mode.SINGLE -> Circle.Companion.circleLifetime
179-
Mode.GROUP -> GroupCircle.Companion.circleLifetime
180-
Mode.ORDER -> OrderCircle.Companion.circleLifetime
179+
Mode.SINGLE -> Circle.circleLifetime
180+
Mode.GROUP -> GroupCircle.circleLifetime
181+
Mode.ORDER -> OrderCircle.circleLifetime
181182
}
182183
)
183184
}
@@ -257,9 +258,10 @@ class Chooser(
257258
soundManager.playFingerUp()
258259
vibrate(40)
259260

260-
handler.postDelayed({
261-
chooseOrder(number + 1)
262-
}, (min(3000 / circles.size, 800).toLong()))
261+
handler.postDelayed(
262+
{ chooseOrder(number + 1) },
263+
min(3000L / circles.size, 800L)
264+
)
263265
}
264266

265267
private fun vibrate(millis: Long) {

app/src/main/java/com/uravgcode/chooser/chooser/presentation/circle/Circle.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ open class Circle(var x: Float, var y: Float, radius: Float, var color: Int) {
6161

6262
protected var timeMillis = 0L
6363

64-
open fun update(deltaTime: Int) {
64+
open fun update(deltaTime: Long) {
6565
val radius = coreRadius + radiusVariance * sin(timeMillis * 0.006f)
6666
val innerRadius = radius * 0.6f
6767
val strokeWidth = radius * 0.19f

app/src/main/java/com/uravgcode/chooser/chooser/presentation/circle/GroupCircle.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class GroupCircle(x: Float, y: Float, radius: Float) : Circle(x, y, radius, Colo
3131
ringPaintLight.color = grayStroke
3232
}
3333

34-
override fun update(deltaTime: Int) {
34+
override fun update(deltaTime: Long) {
3535
super.update(deltaTime)
3636
if (color == corePaint.color || blend > 1f) return
3737

app/src/main/java/com/uravgcode/chooser/chooser/presentation/circle/OrderCircle.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class OrderCircle(x: Float, y: Float, radius: Float, color: Int) : Circle(x, y,
4242

4343
private var number: Int? = null
4444

45-
override fun update(deltaTime: Int) {
45+
override fun update(deltaTime: Long) {
4646
super.update(deltaTime)
4747
corePaint.color = if (coreRadius <= defaultRadius) {
4848
color

app/src/main/java/com/uravgcode/chooser/chooser/presentation/component/Number.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ class Number(private var x: Float, private var y: Float, color: Int, private val
3030
private val xOrigin = x
3131
private var alpha = 255f
3232
private var alphaSpeed = 0f
33-
private var time = 0
33+
private var time = 0L
3434

35-
fun update(deltaTime: Int) {
35+
fun update(deltaTime: Long) {
3636
alphaSpeed += deltaTime * 0.00004f
3737
alpha -= alphaSpeed * deltaTime
3838
alphaSpeed += deltaTime * 0.00004f

app/src/main/java/com/uravgcode/chooser/chooser/presentation/manager/CircleManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class CircleManager : MutableMap<Int, Circle> {
4545
}
4646
}
4747

48-
fun update(deltaTime: Int) {
48+
fun update(deltaTime: Long) {
4949
activeCircles.forEach { (_, circle) -> circle.update(deltaTime) }
5050
deadCircles.forEach { it.update(deltaTime) }
5151
deadCircles.removeAll { it.isMarkedForDeletion() }

0 commit comments

Comments
 (0)