refactor custom command syntax exceptions

Author: UrAvgCode

src/main/java/com/uravgcode/modernessentials/argument/OtherPlayerArgument.java

@@ -4,10 +4,10 @@
 import com.mojang.brigadier.arguments.ArgumentType;
 import com.mojang.brigadier.context.CommandContext;
 import com.mojang.brigadier.exceptions.CommandSyntaxException;
+import com.mojang.brigadier.exceptions.SimpleCommandExceptionType;
 import com.mojang.brigadier.suggestion.Suggestions;
 import com.mojang.brigadier.suggestion.SuggestionsBuilder;
 import com.uravgcode.modernessentials.exception.BadSourceException;
-import com.uravgcode.modernessentials.exception.CannotTargetSelfException;
 import io.papermc.paper.command.brigadier.CommandSourceStack;
 import io.papermc.paper.command.brigadier.argument.ArgumentTypes;
 import io.papermc.paper.command.brigadier.argument.CustomArgumentType;
@@ -19,6 +19,7 @@
 
 @NullMarked
 public class OtherPlayerArgument implements CustomArgumentType<Player, PlayerSelectorArgumentResolver> {
+    private static final SimpleCommandExceptionType INVALID_TARGET = new SimpleCommandExceptionType(() -> "You cannot target yourself");
 
     @Override
     public Player parse(StringReader reader) {
@@ -31,7 +32,7 @@ public <S> Player parse(StringReader reader, S source) throws CommandSyntaxExcep
 
         final var sender = stack.getSender();
         final var player = getNativeType().parse(reader).resolve(stack).getFirst();
-        if (player.equals(sender)) throw new CannotTargetSelfException();
+        if (player.equals(sender)) throw INVALID_TARGET.create();
 
         return player;
     }

src/main/java/com/uravgcode/modernessentials/argument/TpaPlayerArgument.java

@@ -14,12 +14,12 @@
 
 @NullMarked
 public final class TpaPlayerArgument extends OtherPlayerArgument {
-    private final SimpleCommandExceptionType invalidTargetExceptionType = new SimpleCommandExceptionType(() -> "Target cannot accept teleport requests");
+    private static final SimpleCommandExceptionType INVALID_TARGET = new SimpleCommandExceptionType(() -> "Target cannot accept teleport requests");
 
     @Override
     public <S> Player parse(StringReader reader, S source) throws CommandSyntaxException {
         final var target = super.parse(reader, source);
-        if (!target.hasPermission("essentials.tpa.accept")) throw invalidTargetExceptionType.create();
+        if (!target.hasPermission("essentials.tpa.accept")) throw INVALID_TARGET.create();
         return target;
     }
 

src/main/java/com/uravgcode/modernessentials/exception/BadSourceException.java

@@ -4,11 +4,9 @@
 import com.mojang.brigadier.exceptions.CommandExceptionType;
 import com.mojang.brigadier.exceptions.CommandSyntaxException;
 import com.mojang.brigadier.exceptions.SimpleCommandExceptionType;
-import io.papermc.paper.command.brigadier.MessageComponentSerializer;
-import net.kyori.adventure.text.Component;
 
 public final class BadSourceException extends CommandSyntaxException {
-    private static final Message message = MessageComponentSerializer.message().serialize(Component.text("The source needs to be a command source stack"));
+    private static final Message message = () -> "The source needs to be a command source stack";
     private static final CommandExceptionType type = new SimpleCommandExceptionType(message);
 
     public BadSourceException() {

src/main/java/com/uravgcode/modernessentials/exception/CannotTargetSelfException.java

@@ -4,11 +4,10 @@
 import com.mojang.brigadier.exceptions.CommandExceptionType;
 import com.mojang.brigadier.exceptions.CommandSyntaxException;
 import com.mojang.brigadier.exceptions.SimpleCommandExceptionType;
-import io.papermc.paper.command.brigadier.MessageComponentSerializer;
-import net.kyori.adventure.text.Component;
+import net.minecraft.network.chat.Component;
 
 public final class NoPlayerFoundException extends CommandSyntaxException {
-    private static final Message message = MessageComponentSerializer.message().serialize(Component.translatable("argument.entity.notfound.player"));
+    private static final Message message = Component.translatable("argument.entity.notfound.player");
     private static final CommandExceptionType type = new SimpleCommandExceptionType(message);
 
     public NoPlayerFoundException() {

src/main/java/com/uravgcode/modernessentials/exception/NoPlayerFoundException.java

@@ -4,11 +4,10 @@
 import com.mojang.brigadier.exceptions.CommandExceptionType;
 import com.mojang.brigadier.exceptions.CommandSyntaxException;
 import com.mojang.brigadier.exceptions.SimpleCommandExceptionType;
-import io.papermc.paper.command.brigadier.MessageComponentSerializer;
-import net.kyori.adventure.text.Component;
+import net.minecraft.network.chat.Component;
 
 public final class RequiresPlayerException extends CommandSyntaxException {
-    private static final Message message = MessageComponentSerializer.message().serialize(Component.translatable("permissions.requires.player"));
+    private static final Message message = Component.translatable("permissions.requires.player");
     private static final CommandExceptionType type = new SimpleCommandExceptionType(message);
 
     public RequiresPlayerException() {