Skip to content

Commit 13aff62

Browse files
authored
Fixed PR workflow double zipping (#1162)
* Added .zip extension to avoid double zipping * Fixed double zip
1 parent 64a0667 commit 13aff62

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/pr-build-env.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ jobs:
7474
run: /bin/sh scripts/${{ inputs.env }}/mkzip.sh
7575

7676
- name: Upload zip as artifact
77-
uses: actions/upload-artifact@v4
77+
uses: actions/upload-artifact@v7
7878
with:
79-
name: ${{ inputs.env }}
79+
name: ${{ inputs.env }}.zip
8080
path: ${{ inputs.env }}.zip
81+
archive: false
8182
retention-days: 7

.github/workflows/pull-request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
7979
const envs = ['esp32s2', 'esp32s3', 'esp32c3', 'esp32', 'esp32solo', 'esp8266'];
8080
const lines = envs.map(env => {
81-
const artifact = artifacts.find(a => a.name === env);
81+
const artifact = artifacts.find(a => a.name === `${env}.zip`);
8282
if (artifact) {
8383
// The artifact download page URL - directly navigable in the browser
8484
const artifactUrl = `${runUrl}#artifacts-${env}`;

0 commit comments

Comments
 (0)