Movies/TvShows: drop language parameter for external IDs method

Author: UweTrottmann

CHANGELOG.md

@@ -7,6 +7,8 @@ Change Log
 * Add `rent` to `WatchProviders.CountryInfo` that contains rental providers for a movie.
 * `DiscoverTvBuilder`: add `vote_average_lte` and `vote_count_lte`. [#103](https://github.com/UweTrottmann/tmdb-java/issues/103)
 * Add `spoken_languages` to `TvShow`, add `english_name` to `SpokenLanguage`. [#91](https://github.com/UweTrottmann/tmdb-java/issues/91)
+* Deprecate `externalIds` methods that accept a `language` parameter, it was never supported. Use the replacements 
+  without it.
 
 ## 2.11.0
 _2024-06-07_

src/main/java/com/uwetrottmann/tmdb2/services/MoviesService.java

@@ -133,16 +133,24 @@ Call<Credits> credits(
             @Path("movie_id") int movieId
     );
 
+    /**
+     * @deprecated Use {@link #externalIds(int)} instead. This method never supported a language parameter.
+     */
+    @Deprecated
+    @GET("movie/{movie_id}/external_ids")
+    Call<MovieExternalIds> externalIds(
+            @Path("movie_id") int movieId,
+            @Query("language") String language
+    );
+
     /**
      * Get the external ids that we have stored for a movie.
      *
      * @param movieId A Movie TMDb id.
-     * @param language <em>Optional.</em> ISO 639-1 code.
      */
     @GET("movie/{movie_id}/external_ids")
     Call<MovieExternalIds> externalIds(
-            @Path("movie_id") int movieId,
-            @Query("language") String language
+            @Path("movie_id") int movieId
     );
 
     /**

src/main/java/com/uwetrottmann/tmdb2/services/TvService.java

@@ -152,16 +152,24 @@ Call<ContentRatings> content_ratings(
             @Path("tv_id") int tmbdId
     );
 
+    /**
+     * @deprecated Use {@link #externalIds(int)} instead. This method never supported a language parameter.
+     */
+    @Deprecated
+    @GET("tv/{tv_id}/external_ids")
+    Call<TvExternalIds> externalIds(
+            @Path("tv_id") int tvShowId,
+            @Query("language") String language
+    );
+
     /**
      * Get the external ids that we have stored for a TV series.
      *
      * @param tvShowId A Tv Show TMDb id.
-     * @param language <em>Optional.</em> ISO 639-1 code.
      */
     @GET("tv/{tv_id}/external_ids")
     Call<TvExternalIds> externalIds(
-            @Path("tv_id") int tvShowId,
-            @Query("language") String language
+            @Path("tv_id") int tvShowId
     );
 
     /**

src/test/java/com/uwetrottmann/tmdb2/services/MoviesServiceTest.java

@@ -173,9 +173,7 @@ public void test_credits() throws IOException {
     @Test
     public void test_externalIds() throws IOException {
         int movieId = 335984;
-        Call<MovieExternalIds> call = getUnauthenticatedInstance().moviesService().externalIds(
-                movieId, null
-        );
+        Call<MovieExternalIds> call = getUnauthenticatedInstance().moviesService().externalIds(movieId);
 
         MovieExternalIds ids = call.execute().body();
         assertThat(ids).isNotNull();

src/test/java/com/uwetrottmann/tmdb2/services/TvServiceTest.java

@@ -220,10 +220,7 @@ public void test_changes() throws IOException {
 
     @Test
     public void test_externalIds() throws IOException {
-        Call<TvExternalIds> call = getUnauthenticatedInstance().tvService().externalIds(
-                testTvShow.id,
-                null
-        );
+        Call<TvExternalIds> call = getUnauthenticatedInstance().tvService().externalIds(testTvShow.id);
 
         TvExternalIds ids = call.execute().body();