Skip to content

Fix game failing tests due to errors. #526

@fire

Description

@fire

Issue description

V-Sekai game fails tests due to errors.

Steps to reproduce

  1. build v-sekai-game on github actions

Minimal reproduction project (For SDK or engine issues)

Run pre-commit run --all-files
[INFO] Initializing environment for local:gdtoolkit==4.3.3.
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
gdlint...................................................................Failed
- hook id: gdlint
- exit code: 1

/home/runner/.cache/pre-commit/repo0kqojm8w/py_env-python3.13/lib/python3.13/site-packages/gdtoolkit/parser/parser.py:8: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
addons/vsk_prop/vsk_prop_definition.gd:9: Error: Constant (load/preload) name "vsk_user_content_definition_helper_const" is not valid (load-constant-name)
Failure: 1 problem found
/home/runner/.cache/pre-commit/repo0kqojm8w/py_env-python3.13/lib/python3.13/site-packages/gdtoolkit/parser/parser.py:8: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
addons/vsk_prop/vsk_prop_entity_instance_record.gd:7: Error: Definition out of order in None (class-definitions-order)
addons/vsk_prop/vsk_prop_definition_editor.gd:9: Error: Constant (load/preload) name "vsk_prop_definition_const" is not valid (load-constant-name)
addons/vsk_prop/vsk_prop_definition_editor.gd:10: Error: Constant (load/preload) name "vsk_prop_definition_runtime_const" is not valid (load-constant-name)
addons/vsk_prop/vsk_prop_definition_editor.gd:14: Error: Constant (load/preload) name "vsk_types_const" is not valid (load-constant-name)
addons/vsk_prop/vsk_prop_definition_editor.gd:15: Error: Constant (load/preload) name "prop_callback_const" is not valid (load-constant-name)
addons/vsk_prop/vsk_prop_definition_editor.gd:22: Error: Definition out of order in None (class-definitions-order)
addons/vsk_prop/vsk_prop_definition_editor.gd:24: Error: Definition out of order in None (class-definitions-order)
addons/vsk_prop/vsk_prop_definition_editor.gd:77: Error: expression is not asigned, and hence it can be removed (expression-not-assigned)
addons/vsk_prop/vsk_prop_definition_editor.gd:82: Error: expression is not asigned, and hence it can be removed (expression-not-assigned)
addons/vsk_prop/vsk_prop_definition_editor.gd:87: Error: expression is not asigned, and hence it can be removed (expression-not-assigned)
Failure: 10 problems found
/home/runner/.cache/pre-commit/repo0kqojm8w/py_env-python3.13/lib/python3.13/site-packages/gdtoolkit/parser/parser.py:8: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
addons/vsk_prop/vsk_prop_plugin.gd:9: Error: Constant (load/preload) name "vsk_prop_definition_editor_const" is not valid (load-constant-name)
Failure: 1 problem found

Using a released version?

No

What OS? Any other relevant information? (V-Sekai version, Godot revision, System information)

Windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions