fix: dev: cleanup compiler flags in cmake and tox, add verbose option

* remove duplicate std flags in favor of standard cmake settings
* remove static flags tox env, set default GNU compiler names
* add verbose make output when set via VERBOSE environment var

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>

Author: sarnold

CMakeLists.txt

@@ -15,6 +15,7 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules)
 OPTION(LIBTINS_BUILD_EXAMPLES "Build examples" ON)
 OPTION(LIBTINS_BUILD_TESTS "Build tests" ON)
 
+
 # Compile in release mode by default
 IF(NOT CMAKE_BUILD_TYPE)
     MESSAGE(STATUS "Setting build type to 'RelWithDebInfo' as none was specified.")
@@ -28,6 +29,10 @@ project(
     LANGUAGES CXX
 )
 
+if(DEFINED ENV{VERBOSE})
+    set(CMAKE_VERBOSE_MAKEFILE ON)
+endif()
+
 # Check the thread library info early as setting compiler flags seems to
 # interfere with the detection and causes CMAKE_THREAD_LIBS_INIT to not
 # include -lpthread when it should.
@@ -76,9 +81,10 @@ SET(TINS_VERSION_MINOR 6)
 SET(TINS_VERSION_PATCH 0)
 SET(LIBTINS_VERSION "${TINS_VERSION_MAJOR}.${TINS_VERSION_MINOR}")
 
-set(CMAKE_CXX_STANDARD 14)
+set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
-set(CMAKE_CXX_EXTENSIONS ON)
+set(CMAKE_CXX_EXTENSIONS OFF)
+MESSAGE(STATUS "Using C++ STD version '${CMAKE_CXX_STANDARD}'")
 
 if(CMAKE_CXX_COMPILER_ID STREQUAL Clang)
     set(CLANG_DEFAULT_CXX_STDLIB libc++)

cmake/Modules/CheckCXXFeatures.cmake

@@ -52,20 +52,6 @@ endif ()
 
 #cmake_minimum_required(VERSION 2.8.3)
 
-#
-### Check for needed compiler flags
-#
-include(CheckCXXCompilerFlag)
-check_cxx_compiler_flag("-std=c++11" _HAS_CXX11_FLAG)
-if (NOT _HAS_CXX11_FLAG)
-    check_cxx_compiler_flag("-std=c++0x" _HAS_CXX0X_FLAG)
-endif ()
-
-if (_HAS_CXX11_FLAG)
-    set(CXX11_COMPILER_FLAGS "-std=c++11")
-elseif (_HAS_CXX0X_FLAG)
-    set(CXX11_COMPILER_FLAGS "-std=c++0x")
-endif ()
 
 function(cxx11_check_feature FEATURE_NAME RESULT_VAR)
     if (NOT DEFINED ${RESULT_VAR})

tox.ini

@@ -10,9 +10,8 @@ install_command = pip install {opts} {packages}
 
 [testenv:tools]
 setenv =
-    CFLAGS = -march=native -O2 -g -DNDEBUG
-    CXXFLAGS = {env:CFLAGS:-march=native -O2 -g -DNDEBUG}
-    LDFLAGS = {env:CFLAGS:-march=native -O2 -g -DNDEBUG} -Wl,-O1 -Wl,--as-needed
+    CC = {env:CC:gcc}
+    CXX = {env:CXX:g++}
     PREFIX = {env:PREFIX:{envdir}}
 
 passenv =
@@ -28,6 +27,7 @@ passenv =
     HOME
     USERNAME
     USER
+    VERBOSE
     CI
     XDG_*
     GITHUB*