refactor(eslint): enable more neostandard configs

Author: VChet

eslint.config.js

@@ -1,14 +1,18 @@
-import { defineConfig, globalIgnores } from "eslint/config";
+import { defineConfig } from "eslint/config";
 import neostandard from "neostandard";
 
 export default defineConfig([
-  globalIgnores(["dist"]),
-  ...neostandard(),
+  ...neostandard({
+    ts: true,
+    noJsx: true,
+    semi: true,
+    ignores: ["dist/**/*"]
+  }),
   {
     rules: {
+      "@stylistic/brace-style": "off",
       "@stylistic/comma-dangle": ["error", "never"],
       "@stylistic/quotes": ["error", "double"],
-      "@stylistic/semi": ["error", "always"],
       "@stylistic/space-before-function-paren": ["error", "never"]
     }
   }

src/output.ts

@@ -10,11 +10,9 @@ function formatSingleBranch(
   for (const prefix of issueUrlPrefix) {
     const prefixRegex = new RegExp(`\\b${prefix}(\\d+)`, "i");
     const match = branch.match(prefixRegex);
-
     if (!match) { continue; }
 
-    const [_fullToken, id] = match;
-    const url = issueUrlFormat.replace("{{prefix}}", prefix).replace("{{id}}", id);
+    const url = issueUrlFormat.replace("{{prefix}}", prefix).replace("{{id}}", match[1]);
     return `${branch} <${url}>`;
   }
   return branch;
@@ -40,7 +38,7 @@ export function outputMergedBranches(branches: string[], targetBranch: string, c
     return console.info(`No branches merged into '${targetBranch}'.`);
   }
 
-  console.info(`${pluralize(branches.length, ["branch", "branches"])} merged into '${targetBranch}':`)
+  console.info(`${pluralize(branches.length, ["branch", "branches"])} merged into '${targetBranch}':`);
   console.info(formatTaskBranches(branches, config).join("\n"));
 
   const remoteBranches = fetchRemoteBranches("origin");

src/repo.ts

@@ -41,7 +41,7 @@ export function getMergedBranches(targetBranch: string): string[] {
   const output = execSync(`git branch --merged ${targetBranch}`, { encoding: "utf-8" });
   return output.split("\n").reduce((acc: string[], line) => {
     // Ignore empty lines
-    const branch = line.replace('*', '').trim();
+    const branch = line.replace("*", "").trim();
     if (!branch) { return acc; }
     // Ignore branches on the base commit
     const branchCommit = execSync(`git rev-parse ${branch}`, { encoding: "utf-8" }).trim();
@@ -67,7 +67,7 @@ export function fetchRemoteBranches(remote = "origin"): string[] {
 export interface GitMergedConfig {
   issueUrlFormat?: string;
   issueUrlPrefix?: string[];
-};
+}
 
 export function getConfig(): GitMergedConfig {
   try {

src/tests/output.test.ts

@@ -13,8 +13,8 @@ describe("formatTaskBranches", () => {
     const branches = ["feat/TOKEN-800_new-feature", "fix/TOKEN-123_some-fix"];
     const result = formatTaskBranches(branches, DEFAULT_CONFIG);
     expect(result).toEqual([
-      'feat/TOKEN-800_new-feature <https://test-instance.org/browse/TOKEN-800>',
-      'fix/TOKEN-123_some-fix <https://test-instance.org/browse/TOKEN-123>'
+      "feat/TOKEN-800_new-feature <https://test-instance.org/browse/TOKEN-800>",
+      "fix/TOKEN-123_some-fix <https://test-instance.org/browse/TOKEN-123>"
     ]);
   });
 
@@ -81,7 +81,7 @@ describe("outputMergedBranches", () => {
     const branchOutput = [
       "feat/TOKEN-800_new-feature <https://test-instance.org/browse/TOKEN-800>",
       "fix/TOKEN-123_some-fix <https://test-instance.org/browse/TOKEN-123>"
-    ]
+    ];
     expect(infoSpy).toHaveBeenNthCalledWith(2, branchOutput.join("\n"));
 
     const localDelete = `git branch --delete ${branches.join(" ")}`;
@@ -100,7 +100,7 @@ describe("outputMergedBranches", () => {
     const branchOutput = [
       "feat/TOKEN-800_new-feature <https://test-instance.org/browse/TOKEN-800>",
       "fix/TOKEN-123_some-fix <https://test-instance.org/browse/TOKEN-123>"
-    ]
+    ];
     expect(infoSpy).toHaveBeenNthCalledWith(2, branchOutput.join("\n"));
 
     const localDelete = `git branch --delete ${branches.join(" ")}`;
@@ -126,7 +126,7 @@ describe("outputMergedBranches", () => {
     expect(infoSpy).toHaveBeenNthCalledWith(4, `locally:\n  ${localDelete}`);
     expect(infoSpy).toHaveBeenCalledTimes(4);
     expect(warnSpy).not.toHaveBeenCalled();
-  })
+  });
 
   it("should log a message when no branches are merged", () => {
     outputMergedBranches([], "master", DEFAULT_CONFIG);

src/validate.ts

@@ -1,8 +1,8 @@
-export function isValidURL(url?: string): boolean {
-  if (!url) return false;
+export function isValidURL(payload?: string): boolean {
+  if (!payload) return false;
   try {
-    new URL(url);
-    return true;
+    const url = new URL(payload);
+    return url.protocol === "http:" || url.protocol === "https:";
   } catch {
     return false;
   }