Skip to content

Update validation_analysis.py #38

@samanthalwong

Description

@samanthalwong
          I believe [gammapy_tools/analysis/validation_analysis.py ](https://github.com/VERITAS-Observatory/gammapy-tools/blob/main/gammapy_tools/analysis/validation_analysis.py) may also have problems. If this file should not be used in its current state then it should probably be removed. 

I have been able to run analysis successfully with all of these notebooks (including analysis_notebook.pynb) but I'm just recording the errors that will pop up anytime any notebook references make_spectrum_RE() with pos_from_DL3. The other notebooks don't contain this helper function so the error does not occur. The RBM_analysis notebook is able to still get outputs that this helper function should generate by rewriting some of the functions that the wrapper should handle for you so I don't think it running is a good benchmark for testing the full functionality of the helper functions included in this package, it's more of a test of just using gammapy.

Originally posted by @matthew-w-lundy in #34 (comment)

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomersminor issueNeeds to be fixed but isn't crucial for analysis

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions