Skip to content

Commit 5651397

Browse files
chore: upgrade to Very Good Analysis 10.0.0 (#1600)
<!-- Thanks for contributing! Provide a description of your changes below and a general summary in the title Please look at the following checklist to ensure that your PR can be accepted quickly: --> ## Description Upgrade Very Good Analysis to v10. ## Type of Change <!--- Put an `x` in all the boxes that apply: --> - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🛠️ Bug fix (non-breaking change which fixes an issue) - [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change) - [ ] 🧹 Code refactor - [ ] ✅ Build configuration change - [ ] 📝 Documentation - [x] 🗑️ Chore --------- Co-authored-by: Josh-Sanford <josh.sanford@verygood.ventures> Co-authored-by: Josh-Sanford <52753338+Josh-Sanford@users.noreply.github.com>
1 parent 3c9e95f commit 5651397

File tree

156 files changed

+290
-328
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

156 files changed

+290
-328
lines changed

flutter_news_example/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.7.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.10.0.0.yaml
22
analyzer:
33
errors:
44
document_ignores: ignore

flutter_news_example/api/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.7.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.10.0.0.yaml
22
analyzer:
33
errors:
44
document_ignores: ignore

flutter_news_example/api/lib/src/client/flutter_news_example_api_client.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ class FlutterNewsExampleApiClient {
166166
}) async {
167167
final uri = Uri.parse('$_baseUrl/api/v1/feed').replace(
168168
queryParameters: <String, String>{
169-
if (categoryId != null) 'category': categoryId,
169+
'category': ?categoryId,
170170
if (limit != null) 'limit': '$limit',
171171
if (offset != null) 'offset': '$offset',
172172
},

flutter_news_example/api/lib/src/data/static_news_data.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1435,7 +1435,7 @@ const _technologyCategory = Category(id: 'technology', name: 'Technology');
14351435
const _healthCategory = Category(id: 'health', name: 'Health');
14361436
const _scienceCategory = Category(id: 'science', name: 'Science');
14371437

1438-
const _categories = [
1438+
const List<Category> _categories = [
14391439
_topCategory,
14401440
_sportsCategory,
14411441
_technologyCategory,

flutter_news_example/api/packages/news_blocks/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.7.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.10.0.0.yaml
22
analyzer:
33
errors:
44
document_ignores: ignore

flutter_news_example/api/packages/news_blocks/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ dev_dependencies:
1717
json_serializable: ^6.9.5
1818
mocktail: ^1.0.2
1919
test: ^1.21.4
20-
very_good_analysis: ^7.0.0
20+
very_good_analysis: ^10.0.0
2121

2222
dependency_overrides:
2323
frontend_server_client: ^4.0.0

flutter_news_example/api/packages/news_blocks/test/src/block_action_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ignore_for_file: prefer_const_constructors_in_immutables, lines_longer_than_80_chars, prefer_const_constructors
1+
// ignore_for_file: prefer_const_constructors
22

33
import 'package:news_blocks/news_blocks.dart';
44
import 'package:test/test.dart';

flutter_news_example/api/packages/news_blocks/test/src/trending_story_block_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// ignore_for_file: prefer_const_constructors
2-
31
import 'package:news_blocks/news_blocks.dart';
42
import 'package:test/test.dart';
53

flutter_news_example/api/packages/news_blocks/test/src/video_intro_block_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// ignore_for_file: prefer_const_constructors
2-
31
import 'package:news_blocks/news_blocks.dart';
42
import 'package:test/test.dart';
53

flutter_news_example/api/pubspec.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -524,10 +524,10 @@ packages:
524524
dependency: "direct dev"
525525
description:
526526
name: very_good_analysis
527-
sha256: "62d2b86d183fb81b2edc22913d9f155d26eb5cf3855173adb1f59fac85035c63"
527+
sha256: "96245839dbcc45dfab1af5fa551603b5c7a282028a64746c19c547d21a7f1e3a"
528528
url: "https://pub.dev"
529529
source: hosted
530-
version: "7.0.0"
530+
version: "10.0.0"
531531
vm_service:
532532
dependency: transitive
533533
description:

0 commit comments

Comments
 (0)