[FEAT] Include the host nvidia driver first in `__EGL_VENDOR_LIBRARY_DIRS`

[Samueru-sama]

Context: pkgforge-dev/ghostty-appimage#93 (comment)

This is actually a bug in mesa though, but would be great to make sure the nvidia prop driver gets loaded first to avoid this from ever happening again.

Putting the nvidia driver first in __EGL_VENDOR_LIBRARY_DIRS would do the same as what I suggested of removing AppDir/share/glvnd.

For this to be done sharun would need to check if /usr/share/glvnd/egl_vendor.d/10_nvidia.json is present then give priority to it.

[Samueru-sama]

Likely related: probonopd/PrusaSlicer#5

This was also a bug in mesa that prevented the prop nvidia driver from loading, this would have been avoided all together if sharun gives priority to the nvidia icd.

[Samueru-sama]

Also I'm noticing that the opengl loaders are named:

10_nvidia.json
50_mesa.json

This means that when people have the prop nvidia driver installed, the 10_nvidia.json gets loaded first always, which does not happen when sharun sets the bundled mesa first in __EGL_VENDOR_LIBRARY_DIRS

EDIT: The issue was "fixed" by making a symlink in the AppDir pkgforge-dev/ghostty-appimage#95

[VHSgunzo]

this is not reproduced in my system. I downloaded the release with symlink and deleted the symlink, and I didn't get any problems at launch, because I have a globally set environment variable __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/10_nvidia.json

I think this should be solved on the user side

But of course I can add to sharun a search for the file /usr/share/glvnd/egl_vendor.d/10_nvidia.json and, if it exists, then set the variable __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/10_nvidia.json
if this variable wasn't set before

[Samueru-sama]

this is not reproduced in my system. I downloaded the release with symlink and deleted the symlink, and I didn't get any problems at launch, because I have a globally set environment variable __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/10_nvidia.json

And can you reproduce if you unset __EGL_VENDOR_LIBRARY_FILENAMES?

But of course I can add to sharun a search for the file /usr/share/glvnd/egl_vendor.d/10_nvidia.json and, if it exists, then set the variable __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/10_nvidia.json
if this variable wasn't set before

sounds good but I would need to ask the user if the issue gets fixed after doing that if you cannot reproduce the issue.

[VHSgunzo]

And can you reproduce if you unset __EGL_VENDOR_LIBRARY_FILENAMES?

yes

[VHSgunzo]

Fix:

"glvnd" => {
    if get_env_var("__EGL_VENDOR_LIBRARY_FILENAMES").is_empty() {
        for xdg_data_dir in xdg_data_dirs.rsplit(":") {
            let nvidia_json_path = Path::new(xdg_data_dir).join("glvnd/egl_vendor.d/10_nvidia.json");
            if nvidia_json_path.exists() {
                env::set_var("__EGL_VENDOR_LIBRARY_FILENAMES", &nvidia_json_path);
                break
            }
        }
    }
    add_to_xdg_data_env(xdg_data_dirs,
        "__EGL_VENDOR_LIBRARY_DIRS", "glvnd/egl_vendor.d")
}

[VHSgunzo]

NVIDIA/libglvnd#187

• If the environment variable __EGL_VENDOR_LIBRARY_FILENAMES is set, it is a colon-separated list of JSON filenames. The ICDs described in those files are loaded, in the order given. No other ICDs are loaded.
• Otherwise, if the environment variable __EGL_VENDOR_LIBRARY_DIRS is set, it is a colon-separated list of directories. Each directory in turn is scanned for files named *.json and the ICDs that they describe are loaded. Files in the same directory are loaded in arbitrary order.

[VHSgunzo]

https://github.com/VHSgunzo/sharun/releases/tag/v0.7.6