Merge branch 'master' into node-gateway

Signed-off-by: al3xa23 <140614263+al3xa23@users.noreply.github.com>

Author: al3xa23

.clang-tidy

@@ -0,0 +1,9 @@
+# SPDX-FileCopyrightText: 2025 Institute for Automation of Complex Power Systems, RWTH Aachen University
+# SPDX-License-Identifier: Apache-2.0
+
+Checks: >
+  -*,
+  modernize-use-override,
+WarningsAsErrors: '*'
+HeaderFilterRegex: villas/.*
+FormatStyle: file

.gitlab-ci.yml

@@ -164,7 +164,7 @@ test:python:
     - pytest --verbose .
     - black --line-length=90 --extend-exclude=".*(\\.pyi|_pb2.py)$" --check .
     - flake8 --max-line-length=90 --extend-exclude="*.pyi,*_pb2.py" .
-    - mypy --explicit-package-bases villas/
+    - mypy --namespace-packages --explicit-package-bases .
   image: ${DOCKER_IMAGE_DEV}:${DOCKER_TAG}
   needs:
     - job: "build:source: [fedora]"
@@ -267,7 +267,7 @@ pkg:nix:arx:
       nix bundle
       --print-build-logs
       --out-link bundle-arx
-      --bundler github:NixOS/bundlers#toArx
+      --bundler github:nix-community/nix-bundle
       ".#villas-node-${SYSTEM}"
 
     - mkdir -p artifacts

CMakeLists.txt

@@ -52,7 +52,14 @@ include(FindSymbol)
 include(CMakeDependentOption)
 
 add_definitions(-D_POSIX_C_SOURCE=200809L -D_GNU_SOURCE)
-add_compile_options(-Wall -Wno-unknown-pragmas -fdiagnostics-color=auto)
+add_compile_options(
+    -Wall
+    -Wno-unknown-pragmas
+    -Wno-unknown-warning-option
+    -Wno-vla-cxx-extension
+    -Wno-unused-command-line-argument
+    -fdiagnostics-color=auto
+)
 
 # Check OS
 check_include_file("sys/eventfd.h" HAS_EVENTFD)

clients/shmem/villas-shmem.cpp

@@ -34,7 +34,7 @@ class Shmem : public Tool {
 protected:
   std::atomic<bool> stop;
 
-  void usage() {
+  void usage() override {
     std::cout
         << "Usage: villas-test-shmem WNAME VECTORIZE" << std::endl
         << "  WNAME     name of the shared memory object for the output queue"
@@ -47,9 +47,9 @@ class Shmem : public Tool {
     printCopyright();
   }
 
-  void handler(int, siginfo_t *, void *) { stop = true; }
+  void handler(int, siginfo_t *, void *) override { stop = true; }
 
-  int main() {
+  int main() override {
     int ret, readcnt, writecnt, avail;
 
     struct ShmemInterface shm;

common/include/villas/cpuset.hpp

@@ -80,7 +80,9 @@ class CpuSet {
     return full ^ *this;
   }
 
-  bool operator==(const CpuSet &rhs) { return CPU_EQUAL_S(sz, setp, rhs.setp); }
+  friend bool operator==(const CpuSet &lhs, const CpuSet &rhs) {
+    return CPU_EQUAL_S(lhs.sz, lhs.setp, rhs.setp);
+  }
 
   CpuSet &operator&=(const CpuSet &rhs) {
     CPU_AND_S(sz, setp, setp, rhs.setp);

common/include/villas/dsp/window_cosine.hpp

@@ -27,7 +27,7 @@ class CosineWindow : public Window<T> {
 
   T correctionFactor;
 
-  virtual T filter(T in, size_type i) const { return in * coefficients[i]; }
+  T filter(T in, size_type i) const override { return in * coefficients[i]; }
 
 public:
   CosineWindow(double a0, double a1, double a2, double a3, double a4,

common/include/villas/exceptions.hpp

@@ -90,7 +90,7 @@ class ConfigError : public std::runtime_error {
   }
 
 public:
-  ~ConfigError() {
+  ~ConfigError() override {
     if (msg)
       free(msg);
   }

common/include/villas/kernel/devices/driver.hpp

@@ -1,4 +1,4 @@
-/* Interface for device drivers. OS/platform independend.
+/* Interface for device drivers. OS/platform independent.
  * Implemented for Linux/Unix drivers in linux_driver.hpp
  *
  * Author: Pascal Bauer <pascal.bauer@rwth-aachen.de>
@@ -24,6 +24,7 @@ class Driver {
   virtual std::string name() const = 0;
   virtual void override(const Device &device) const = 0;
   virtual void unbind(const Device &device) const = 0;
+  virtual ~Driver() = default;
 };
 
 } // namespace devices

common/include/villas/kernel/vfio_device.hpp

@@ -98,9 +98,6 @@ class Device {
   std::vector<struct vfio_region_info> regions;
   std::vector<void *> mappings;
 
-  // libpci handle of the device
-  const kernel::devices::PciDevice *pci_device;
-
   Logger log;
 };
 

common/include/villas/memory.hpp

@@ -135,8 +135,9 @@ template <typename DerivedAllocator> class BaseAllocator {
     derivedAlloc = nullptr;
   }
 
-  virtual std::unique_ptr<MemoryBlock, MemoryBlock::deallocator_fn>
+  virtual ~BaseAllocator() = default;
 
+  virtual std::unique_ptr<MemoryBlock, MemoryBlock::deallocator_fn>
   allocateBlock(size_t size) = 0;
 
   template <typename T> MemoryAccessor<T> allocate(size_t num) {
@@ -217,8 +218,8 @@ class LinearAllocator : public BaseAllocator<LinearAllocator> {
 
   std::string getName() const;
 
-  virtual std::unique_ptr<MemoryBlock, MemoryBlock::deallocator_fn>
-  allocateBlock(size_t size);
+  std::unique_ptr<MemoryBlock, MemoryBlock::deallocator_fn>
+  allocateBlock(size_t size) override;
 
 private:
   static constexpr size_t alignBytes = sizeof(uintptr_t);
@@ -247,7 +248,7 @@ class HostRam {
     std::string getName() const { return "HostRamAlloc"; }
 
     std::unique_ptr<MemoryBlock, MemoryBlock::deallocator_fn>
-    allocateBlock(size_t size);
+    allocateBlock(size_t size) override;
   };
 
   static HostRamAllocator &getAllocator() {
@@ -264,7 +265,7 @@ class HostDmaRam {
   public:
     HostDmaRamAllocator(int num);
 
-    virtual ~HostDmaRamAllocator();
+    ~HostDmaRamAllocator() override;
 
     std::string getName() const { return getUdmaBufName(num); }