cleanup(utils): Remove unnecessary read_names_in_directory helper

Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>

Author: pjungkamp

common/include/villas/utils.hpp

@@ -132,7 +132,6 @@ template <class... Ts> struct overloaded : Ts... {
 template <class... Ts> overloaded(Ts...) -> overloaded<Ts...>;
 
 void write_to_file(std::string data, const fs::path file);
-std::vector<std::string> read_names_in_directory(const fs::path &directory);
 
 namespace base64 {
 

common/lib/kernel/devices/ip_device.cpp

@@ -58,13 +58,9 @@ std::vector<villas::kernel::devices::IpDevice>
 IpDevice::from_directory(fs::path devices_directory) {
   std::vector<villas::kernel::devices::IpDevice> devices;
 
-  const std::vector<std::string> devicetree_names =
-      villas::utils::read_names_in_directory(devices_directory);
-
-  for (auto devicetree_name : devicetree_names) {
-    auto path_to_device = devices_directory / fs::path(devicetree_name);
+  for (auto devicetree : fs::directory_iterator{devices_directory}) {
     try {
-      auto device = villas::kernel::devices::IpDevice::from(path_to_device);
+      auto device = villas::kernel::devices::IpDevice::from(devicetree.path());
       devices.push_back(device);
     } catch (std::runtime_error &e) {
     }

common/lib/utils.cpp

@@ -364,13 +364,5 @@ void write_to_file(std::string data, const fs::path file) {
   }
 }
 
-std::vector<std::string> read_names_in_directory(const fs::path &directory) {
-  std::vector<std::string> names;
-  for (auto const &dir_entry : fs::directory_iterator{directory}) {
-    names.push_back(dir_entry.path().filename());
-  }
-  return names;
-}
-
 } // namespace utils
 } // namespace villas