Skip to content

Commit c3f357e

Browse files
SevereCloudactions-user
authored andcommitted
fix: img loading order (#9433)
1 parent f2ed352 commit c3f357e

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/vkui/src/components/ContentCard/ContentCard.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,17 @@ export const ContentCard = ({
102102
>
103103
{(src || srcSet) && (
104104
<img
105+
// safari и firefox нужно чтобы атрибут `loading` был до `src`
106+
//
107+
// https://mihaly4.ru/image-loading-lazy-bug
108+
loading={loading}
105109
ref={getRef}
106110
className={styles.img}
107111
src={src}
108112
srcSet={srcSet}
109113
alt={alt}
110114
crossOrigin={crossOrigin}
111115
decoding={decoding}
112-
loading={loading}
113116
referrerPolicy={referrerPolicy}
114117
sizes={sizes}
115118
useMap={useMap}

packages/vkui/src/components/ImageBase/ImageBase.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,10 @@ export const ImageBase: React.FC<ImageBaseProps> & {
257257
} = useMergeProps<React.ComponentProps<'img'> & HasRootRef<HTMLImageElement> & HasDataAttribute>(
258258
hasSrc
259259
? {
260+
// safari и firefox нужно чтобы атрибут `loading` был до `src`
261+
//
262+
// https://mihaly4.ru/image-loading-lazy-bug
263+
loading,
260264
getRootRef: getRef,
261265
alt,
262266
className: classNames(
@@ -269,7 +273,6 @@ export const ImageBase: React.FC<ImageBaseProps> & {
269273
),
270274
crossOrigin,
271275
decoding,
272-
loading,
273276
referrerPolicy,
274277
style: mergeStyle(
275278
keepAspectRatio

0 commit comments

Comments
 (0)