added a check for the presence of #pragma once in files (#1478)

Author: Danil42Russia

.github/workflows/pr-code-format.yml

@@ -34,6 +34,21 @@ jobs:
             exit 1
           fi
 
+      - name: Check "#pragma once" in files
+        run: |
+          EXIT_CODE=0
+          for file in $(find . -name '*.h' -type f \( -path './common/*' -o -path './runtime/*' -o -path './runtime-common/*'  -o -path './runtime-light/*' \)); do
+            if [[ $( grep -q -E '^#pragma\ once' "$file" )$? -ne 0 ]]; then
+              echo "Missing '#pragma once' in file '$file'"
+              EXIT_CODE=1
+            fi
+          done
+          
+          if [[ $EXIT_CODE -ne 0 ]]; then
+            echo "There are errors in the files, please fix them.";
+            exit 1
+          fi
+
       - name: Install clang-format
         run: sudo apt-get install -y clang-format-18
 

common/algorithms/arithmetic.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef ENGINE_ALGO_ARITHMETIC_H
-#define ENGINE_ALGO_ARITHMETIC_H
+#pragma once
 
 #include <limits.h>
 #include <stdlib.h>
@@ -18,5 +17,3 @@ static inline int saturating_abs(int x) {
 static inline int align4(int x) {
   return (x + 3) & -4;
 }
-
-#endif // ENGINE_ALGO_ARITHMETIC_H

common/algorithms/compare.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef ENGINE_COMMON_ALGO_COMPARE_H
-#define ENGINE_COMMON_ALGO_COMPARE_H
+#pragma once
 
 #include <algorithm>
 #include <iterator>
@@ -44,5 +43,3 @@ bool any_of(const Range& range, Predicate p) {
 }
 
 } // namespace vk
-
-#endif // ENGINE_COMMON_ALGO_COMPARE_H

common/algorithms/hashes.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef ENGINE_HASHES_H
-#define ENGINE_HASHES_H
+#pragma once
 
 #include <array>
 #include <cstddef>
@@ -95,5 +94,3 @@ class hash<vk::span<T>> {
 };
 
 } // namespace std
-
-#endif // ENGINE_HASHES_H

common/allocators/freelist.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef KDB_COMMON_ALLOCATORS_FREELIST_H
-#define KDB_COMMON_ALLOCATORS_FREELIST_H
+#pragma once
 
 #include <sys/cdefs.h>
 
@@ -20,5 +19,3 @@ void freelist_init(freelist_t* freelist);
 void* freelist_get(freelist_t* freelist);
 bool freelist_try_put(freelist_t* freelist, void* ptr);
 void freelist_put(freelist_t* freelist, void* ptr);
-
-#endif // KDB_COMMON_ALLOCATORS_FREELIST_H

common/allocators/lockfree-slab.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef KDB_COMMON_ALLOCATORS_LOCKFREE_SLAB_H
-#define KDB_COMMON_ALLOCATORS_LOCKFREE_SLAB_H
+#pragma once
 
 #include <sys/cdefs.h>
 #include <sys/queue.h>
@@ -73,5 +72,3 @@ static inline void* lockfree_slab_cache_alloc0(lockfree_slab_cache_tls_t* cache_
 
 void lockfree_slab_cache_free(lockfree_slab_cache_tls_t* cache_tls, void* object);
 void lockfree_slab_cache_clear(lockfree_slab_cache_tls_t* cache_tls);
-
-#endif // KDB_COMMON_ALLOCATORS_LOCKFREE_SLAB_H

common/binlog/binlog-buffer-replay.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef ENGINE_BINLOG_BUFFER_REPLAY_H
-#define ENGINE_BINLOG_BUFFER_REPLAY_H
+#pragma once
 
 #include <stddef.h>
 
@@ -23,5 +22,3 @@ hash_t bb_buffer_calc_binlog_hash(struct bb_buffer* B, struct lev_rotate_to* nex
 hash_t binlog_relax_hash(hash_t prev_hash, long long pos, unsigned log_crc32);
 
 extern struct bb_reader_functions bbr_replay_functions;
-
-#endif // ENGINE_BINLOG_BUFFER_REPLAY_H

common/binlog/binlog-buffer-rotation-points.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef ENGINE_BINLOG_BUFFER_ROTATION_POINTS_H
-#define ENGINE_BINLOG_BUFFER_ROTATION_POINTS_H
+#pragma once
 
 #include <sys/cdefs.h>
 
@@ -20,5 +19,3 @@ void bb_rotation_point_assign(struct bb_rotation_point** lhs, struct bb_rotation
 
 void bb_rotation_point_close_binlog(struct bb_rotation_point* p);
 void bb_rotation_point_free(struct bb_rotation_point* p);
-
-#endif // ENGINE_BINLOG_BUFFER_ROTATION_POINTS_H

common/binlog/binlog-buffer.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2020 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef __KDB_BINLOG_BUFFER_H__
-#define __KDB_BINLOG_BUFFER_H__
+#pragma once
 
 #include <aio.h>
 #include <functional>
@@ -175,4 +174,3 @@ void bb_buffer_init(bb_buffer_t* B, bb_writer_t* W, bb_reader_t* R, std::functio
 
 void bb_buffer_open_to_replay(bb_buffer_t* buffer, bb_writer_t* writer, bb_reader_t* reader, kfs_replica_t* replica,
                               std::function<int(const struct lev_generic*, int)> replay_func);
-#endif

common/binlog/binlog-stats.h

@@ -2,8 +2,7 @@
 // Copyright (c) 2024 LLC «V Kontakte»
 // Distributed under the GPL v3 License, see LICENSE.notice.txt
 
-#ifndef KPHP_BINLOG_STATS_H
-#define KPHP_BINLOG_STATS_H
+#pragma once
 
 #include <chrono>
 
@@ -19,4 +18,3 @@ struct binlog_reader_stats : private vk::not_copyable {
   std::chrono::seconds next_binlog_wait_time{std::chrono::seconds::zero()};
   vk::string_view next_binlog_expectator_name;
 };
-#endif // KPHP_BINLOG_STATS_H