fetch_get_pos in all runtimes (#1507)

Author: hrissan

builtin-functions/kphp-full/_functions.txt

@@ -914,6 +914,8 @@ function fetch_memcache_value () ::: mixed;
 function fetch_eof () ::: bool;
 /** @kphp-extern-func-info can_throw */
 function fetch_end () ::: bool;
+/** @kphp-extern-func-info */
+function fetch_get_pos () ::: int;
 
 /** @kphp-extern-func-info can_throw */
 function fetch_lookup_int () ::: int;

builtin-functions/kphp-light/stdlib/rpc.txt

@@ -85,6 +85,9 @@ function fetch_string () ::: string;
 /** @kphp-extern-func-info can_throw */
 function fetch_string2 () ::: string;
 
+/** @kphp-extern-func-info */
+function fetch_get_pos () ::: int;
+
 function store_int ($v ::: int) ::: bool;
 function store_byte ($v ::: int) ::: bool;
 function store_long ($v ::: int) ::: bool;

runtime-light/stdlib/rpc/rpc-api.h

@@ -182,6 +182,10 @@ inline string f$fetch_string2() noexcept {
   return {};
 }
 
+inline int64_t f$fetch_get_pos() noexcept {
+  return static_cast<int64_t>(RpcServerInstanceState::get().tl_fetcher.pos());
+}
+
 inline void f$fetch_raw_vector_double(array<double>& vector, int64_t num_elems) noexcept {
   auto& tl_fetcher{RpcServerInstanceState::get().tl_fetcher};
   const auto len_bytes{sizeof(double) * num_elems};

runtime/rpc.cpp

@@ -483,6 +483,10 @@ bool f$fetch_end() {
   return true;
 }
 
+int64_t f$fetch_get_pos() {
+  return rpc_get_pos();
+}
+
 C$RpcConnection::C$RpcConnection(int32_t host_num, int32_t port, int32_t timeout_ms, int32_t actor_id, int32_t connect_timeout, int32_t reconnect_timeout)
     : host_num(host_num),
       port(port),

runtime/rpc.h

@@ -107,6 +107,8 @@ bool f$fetch_eof();
 
 bool f$fetch_end();
 
+int64_t f$fetch_get_pos();
+
 void f$fetch_raw_vector_double(array<double>& out, int64_t n_elems);
 
 void estimate_and_flush_overflow(size_t& bytes_sent);

vkext/vkext-rpc.cpp

@@ -3112,6 +3112,14 @@ void php_rpc_fetch_end(INTERNAL_FUNCTION_PARAMETERS) { /* {{{ */
 
 /* }}} */
 
+void php_rpc_fetch_get_pos(INTERNAL_FUNCTION_PARAMETERS) { /* {{{ */
+  char *error = 0;
+  int value = do_rpc_fetch_get_pos(&error);
+  RETURN_LONG (value); // do not overcomplicate, any wrong state has position 0
+}
+
+/* }}} */
+
 void php_rpc_queue_create(INTERNAL_FUNCTION_PARAMETERS) { /* {{{ */
   ADD_CNT (parse);
   START_TIMER (parse);

vkext/vkext-rpc.h

@@ -182,6 +182,7 @@ void php_rpc_fetch_float(INTERNAL_FUNCTION_PARAMETERS);
 void php_rpc_fetch_string(INTERNAL_FUNCTION_PARAMETERS);
 void php_rpc_fetch_string2(INTERNAL_FUNCTION_PARAMETERS);
 void php_rpc_fetch_end(INTERNAL_FUNCTION_PARAMETERS);
+void php_rpc_fetch_get_pos(INTERNAL_FUNCTION_PARAMETERS);
 
 void php_rpc_fetch_lookup_int(INTERNAL_FUNCTION_PARAMETERS);
 void php_rpc_fetch_lookup_data(INTERNAL_FUNCTION_PARAMETERS);

vkext/vkext-tl-parse.cpp

@@ -119,9 +119,8 @@ int tl_parse_save_pos() {
   if (error) {
     tl_set_error(error);
     return 0;
-  } else {
-    return r;
   }
+  return r;
 }
 
 int tl_parse_restore_pos(int pos) {

vkext/vkext.cpp

@@ -965,6 +965,13 @@ PHP_FUNCTION (fetch_eof) {
   END_TIMER(total);
 }
 
+PHP_FUNCTION (fetch_get_pos) {
+  ADD_CNT(total);
+  START_TIMER(total);
+  php_rpc_fetch_get_pos(INTERNAL_FUNCTION_PARAM_PASSTHRU);
+  END_TIMER(total);
+}
+
 PHP_FUNCTION (rpc_queue_create) {
   ADD_CNT(total);
   START_TIMER(total);

vkext/vkext.stub.php

@@ -195,6 +195,10 @@ function fetch_eof() : bool {
   return false;
 }
 
+function fetch_get_pos() : int {
+  return 0;
+}
+
 /**
  * @return int|false
  */