[TL2] step 0: added RpcFunctionFetcher (#1407)

Author: hrissan

builtin-functions/kphp-full/_functions.txt

@@ -18,6 +18,7 @@ require_once __DIR__ . '/kphp_toggles.txt';
 require_once __DIR__ . '/kphp_tracing.txt';
 require_once __DIR__ . '/uberh3.txt';
 require_once __DIR__ . '/spl.txt';
+require_once __DIR__ . '/rpc_fetcher.txt';
 require_once __DIR__ . '/ffi.txt';
 require_once __DIR__ . '/kml.txt';
 require_once __DIR__ . '/pdo/PDO.php';

builtin-functions/kphp-full/rpc_fetcher.txt

@@ -0,0 +1,9 @@
+<?php
+
+namespace VK\TL;
+
+/** @kphp-required */
+interface RpcFunctionFetcher {
+  public function typedStore($result ::: RpcFunctionReturnResult);
+  public function typedFetch() : RpcFunctionReturnResult;
+}

builtin-functions/kphp-light/stdlib/rpc.txt

@@ -1,5 +1,7 @@
 <?php
 
+require_once __DIR__ . '/rpc_fetcher.txt';
+
 // ===== SUPPORTED =====
 
 /** @kphp-tl-class */

builtin-functions/kphp-light/stdlib/rpc_fetcher.txt

@@ -0,0 +1,9 @@
+<?php
+
+namespace VK\TL;
+
+/** @kphp-required */
+interface RpcFunctionFetcher {
+  public function typedStore($result ::: RpcFunctionReturnResult);
+  public function typedFetch() : RpcFunctionReturnResult;
+}

common/tl2php/gen-php-code.cpp

@@ -629,6 +629,35 @@ size_t gen_rpc_function_classes(const std::string& out_dir, const PhpClasses& cl
         << std::endl
         << make_class(*repr.function_result) << BuiltinClose{*repr.function_args};
   }
+
+  // we will remove ALL tl2php code soon, so we added a bit hackish code here
+  const char* content = R"(<?php
+
+/**
+ * AUTOGENERATED, DO NOT EDIT! If you want to modify it, check tl schema.
+ *
+ * This autogenerated code represents tl class for typed RPC API.
+ */
+
+#ifndef KPHP
+
+namespace VK\TL;
+
+interface RpcFunctionFetcher {
+
+  /**
+   * @param \VK\TL\RpcFunctionReturnResult $result
+   */
+  public function typedStore($result);
+  /**
+   * @return \VK\TL\RpcFunctionReturnResult
+   */
+  public function typedFetch();
+}
+
+#endif)";
+  std::ofstream{out_dir + "/" + PhpClasses::tl_namespace() + "/RpcFunctionFetcher.php"} << content << std::endl;
+
   return classes.functions.size() * 2;
 }
 

runtime-light/stdlib/rpc/rpc-tl-function.h

@@ -78,6 +78,33 @@ struct C$VK$TL$RpcFunctionReturnResult : abstract_refcountable_php_interface {
   ~C$VK$TL$RpcFunctionReturnResult() override = default;
 };
 
+// Every TL function has a corresponding Fetcher, which captures nat parameters,
+// required to fetch/store function result.
+struct C$VK$TL$RpcFunctionFetcher : abstract_refcountable_php_interface {
+  virtual const char* get_class() const noexcept {
+    return "VK\\TL\\RpcFunctionFetcher";
+  }
+  virtual int32_t get_hash() const noexcept {
+    std::string_view name_view{C$VK$TL$RpcFunctionFetcher::get_class()};
+    return static_cast<int32_t>(vk::murmur_hash<uint32_t>(name_view.data(), name_view.size()));
+  }
+
+  virtual void accept(ToArrayVisitor& /*unused*/) noexcept {}
+  virtual void accept(CommonMemoryEstimateVisitor& /*unused*/) noexcept {}
+  virtual void accept(InstanceReferencesCountingVisitor& /*unused*/) noexcept {}
+  virtual void accept(InstanceDeepCopyVisitor& /*unused*/) noexcept {}
+  virtual void accept(InstanceDeepDestroyVisitor& /*unused*/) noexcept {}
+
+  virtual size_t virtual_builtin_sizeof() const noexcept {
+    return 0;
+  }
+  virtual C$VK$TL$RpcFunctionFetcher* virtual_builtin_clone() const noexcept {
+    return nullptr;
+  }
+
+  ~C$VK$TL$RpcFunctionFetcher() override = default;
+};
+
 // function call response — ReqResult from the TL scheme — is a rpcResponseOk|rpcResponseHeader|rpcResponseError;
 // if it's rpcResponseOk or rpcResponseHeader, then their bodies can be retrieved by a fetcher that was returned by a store
 struct C$VK$TL$RpcResponse : abstract_refcountable_php_interface {

runtime/tl/rpc_function.h

@@ -78,6 +78,33 @@ struct C$VK$TL$RpcFunctionReturnResult : abstract_refcountable_php_interface {
   virtual ~C$VK$TL$RpcFunctionReturnResult() = default;
 };
 
+// Every TL function has a corresponding Fetcher, which captures nat parameters,
+// required to fetch/store function result.
+struct C$VK$TL$RpcFunctionFetcher : abstract_refcountable_php_interface {
+  virtual const char* get_class() const {
+    return "VK\\TL\\RpcFunctionFetcher";
+  }
+  virtual int32_t get_hash() const {
+    std::string_view name_view{C$VK$TL$RpcFunctionFetcher::get_class()};
+    return static_cast<int32_t>(vk::murmur_hash<uint32_t>(name_view.data(), name_view.size()));
+  }
+
+  virtual void accept(ToArrayVisitor&) noexcept {}
+  virtual void accept(CommonMemoryEstimateVisitor&) noexcept {}
+  virtual void accept(InstanceReferencesCountingVisitor&) noexcept {}
+  virtual void accept(InstanceDeepCopyVisitor&) noexcept {}
+  virtual void accept(InstanceDeepDestroyVisitor&) noexcept {}
+
+  virtual size_t virtual_builtin_sizeof() const noexcept {
+    return 0;
+  }
+  virtual C$VK$TL$RpcFunctionFetcher* virtual_builtin_clone() const noexcept {
+    return nullptr;
+  }
+
+  virtual ~C$VK$TL$RpcFunctionFetcher() = default;
+};
+
 // function call response — ReqResult from the TL scheme — is a rpcResponseOk|rpcResponseHeader|rpcResponseError;
 // if it's rpcResponseOk or rpcResponseHeader, then their bodies can be retrieved by a fetcher that was returned by a store
 struct C$VK$TL$RpcResponse : abstract_refcountable_php_interface {

tests/python/tests/rpc/php/VK/TL/RpcFunctionFetcher.php

@@ -0,0 +1,25 @@
+<?php
+
+/**
+ * AUTOGENERATED, DO NOT EDIT! If you want to modify it, check tl schema.
+ *
+ * This autogenerated code represents tl class for typed RPC API.
+ */
+
+#ifndef KPHP
+
+namespace VK\TL;
+
+interface RpcFunctionFetcher {
+
+  /**
+   * @param \VK\TL\RpcFunctionReturnResult $result
+   */
+  public function typedStore($result);
+  /**
+   * @return \VK\TL\RpcFunctionReturnResult
+   */
+  public function typedFetch();
+}
+
+#endif