implement getOffset methods

Author: Shamzik

builtin-functions/kphp-light/stdlib/time-functions.txt

@@ -98,7 +98,6 @@ class DateTimeImmutable implements DateTimeInterface {
   public function sub(DateInterval $interval): DateTimeImmutable;
   public function diff(DateTimeInterface $targetObject, bool $absolute = false): DateInterval;
   public function format(string $format): string;
-  /** @kphp-extern-func-info stub generation-required */
   public function getOffset(): int;
   public function getTimestamp(): int;
 }
@@ -123,7 +122,6 @@ class DateTime implements DateTimeInterface {
   public function sub(DateInterval $interval): DateTime;
   public function diff(DateTimeInterface $targetObject, bool $absolute = false): DateInterval;
   public function format(string $format): string;
-  /** @kphp-extern-func-info stub generation-required */
   public function getOffset(): int;
   public function getTimestamp(): int;
 }

runtime-light/stdlib/time/datetime.cpp

@@ -131,6 +131,10 @@ string f$DateTime$$format(const class_instance<C$DateTime>& self, const string&
   return str;
 }
 
+int64_t f$DateTime$$getOffset(const class_instance<C$DateTime>& self) noexcept {
+  return kphp::timelib::get_offset(*self->time);
+}
+
 int64_t f$DateTime$$getTimestamp(const class_instance<C$DateTime>& self) noexcept {
   return kphp::timelib::get_timestamp(*self->time);
 }

runtime-light/stdlib/time/datetime.h

@@ -59,4 +59,6 @@ class_instance<C$DateInterval> f$DateTime$$diff(const class_instance<C$DateTime>
 
 string f$DateTime$$format(const class_instance<C$DateTime>& self, const string& format) noexcept;
 
+int64_t f$DateTime$$getOffset(const class_instance<C$DateTime>& self) noexcept;
+
 int64_t f$DateTime$$getTimestamp(const class_instance<C$DateTime>& self) noexcept;

runtime-light/stdlib/time/datetimeimmutable.cpp

@@ -169,6 +169,10 @@ string f$DateTimeImmutable$$format(const class_instance<C$DateTimeImmutable>& se
   return str;
 }
 
+int64_t f$DateTimeImmutable$$getOffset(const class_instance<C$DateTimeImmutable>& self) noexcept {
+  return kphp::timelib::get_offset(*self->time);
+}
+
 int64_t f$DateTimeImmutable$$getTimestamp(const class_instance<C$DateTimeImmutable>& self) noexcept {
   return kphp::timelib::get_timestamp(*(self->time));
 }

runtime-light/stdlib/time/datetimeimmutable.h

@@ -65,4 +65,6 @@ class_instance<C$DateInterval> f$DateTimeImmutable$$diff(const class_instance<C$
 
 string f$DateTimeImmutable$$format(const class_instance<C$DateTimeImmutable>& self, const string& format) noexcept;
 
+int64_t f$DateTimeImmutable$$getOffset(const class_instance<C$DateTimeImmutable>& self) noexcept;
+
 int64_t f$DateTimeImmutable$$getTimestamp(const class_instance<C$DateTimeImmutable>& self) noexcept;

runtime-light/stdlib/time/timelib-functions.cpp

@@ -174,6 +174,25 @@ std::string_view english_suffix(timelib_sll number) noexcept {
   return "th";
 }
 
+int64_t get_offset(timelib_time& t) noexcept {
+  if (t.is_localtime) {
+    switch (t.zone_type) {
+    case TIMELIB_ZONETYPE_ID: {
+      time_offset_t offset{(kphp::memory::libc_alloc_guard{}, timelib_get_time_zone_info(t.sse, t.tz_info))};
+      int64_t offset_int{offset->offset};
+      return offset_int;
+    }
+    case TIMELIB_ZONETYPE_OFFSET: {
+      return t.z;
+    }
+    case TIMELIB_ZONETYPE_ABBR: {
+      return t.z + (3600 * t.dst);
+    }
+    }
+  }
+  return 0;
+}
+
 timelib_tzinfo* get_timezone_info(const char* timezone) noexcept {
   int errc{}; // it's intentionally declared as 'int' since timelib_parse_tzfile accepts 'int'
   auto* tzinfo{kphp::timelib::get_timezone_info(timezone, timelib_builtin_db(), std::addressof(errc))};

runtime-light/stdlib/time/timelib-functions.h

@@ -72,6 +72,8 @@ void set_timestamp(timelib_time& t, int64_t timestamp) noexcept;
 
 std::string_view english_suffix(timelib_sll number) noexcept;
 
+int64_t get_offset(timelib_time& t) noexcept;
+
 timelib_tzinfo* get_timezone_info(const char* timezone) noexcept;
 /**
  * @brief Retrieves a pointer to a `timelib_tzinfo` structure for a given time zone name.

tests/phpt/datetime/10_get_offset.php

@@ -1,4 +1,4 @@
-@ok k2_skip
+@ok
 <?php
 
 function test_get_offset() {