fix calloc() argument order

Author: Danil42Russia

common/binlog/binlog-buffer-replay.cpp

@@ -53,9 +53,9 @@ static int bb_writer_rotate(bb_writer_t* W, bb_rotation_point_t* p) {
 
 /******************** replay binlog ********************/
 void bbr_replay_init(bb_reader_t* R) {
-  bbr_replay_extra_t* e = static_cast<bbr_replay_extra_t*>(calloc(sizeof(*e), 1));
+  bbr_replay_extra_t* e = static_cast<bbr_replay_extra_t*>(calloc( 1, sizeof(*e)));
   assert(e);
-  e->wait_job_cb = static_cast<bb_wait_job_cb_t*>(calloc(sizeof(*e->wait_job_cb), 1));
+  e->wait_job_cb = static_cast<bb_wait_job_cb_t*>(calloc(1, sizeof(*e->wait_job_cb)));
   R->extra = e;
 }
 

common/binlog/binlog-buffer-rotation-points.cpp

@@ -79,7 +79,7 @@ static void bb_buffer_insert_rotation_point(bb_buffer_t* B, bb_rotation_point_t*
 }
 
 bb_rotation_point_t* bb_rotation_point_alloc(bb_buffer_t* B, enum bb_rotation_point_type tp, long long log_pos) {
-  auto* p = static_cast<bb_rotation_point_t*>(calloc(sizeof(bb_rotation_point_t), 1));
+  auto* p = static_cast<bb_rotation_point_t*>(calloc(1, sizeof(bb_rotation_point_t)));
   assert(p);
   p->tp = tp;
   p->log_pos = log_pos;

common/kfs/kfs-replica.cpp

@@ -113,7 +113,7 @@ kfs_replica_handle_t open_replica(const char* replica_name, int flags) {
   struct kfs_replica* R = 0;
 
   if (flags & KFS_OPEN_REPLICA_FLAG_FORCE) {
-    R = static_cast<kfs_replica*>(calloc(sizeof(*R), 1));
+    R = static_cast<kfs_replica*>(calloc(1, sizeof(*R)));
     assert(R);
     R->replica_prefix = strdup(replica_name);
     assert(R->replica_prefix);

net/net-aes-keys.cpp

@@ -31,7 +31,7 @@ static size_t aes_loaded_keys_size;
 aes_key_t *default_aes_key;
 
 aes_key_t *create_aes_key() {
-  aes_key_t *key = static_cast<aes_key_t*>(calloc(sizeof(*key), 1));
+  aes_key_t *key = static_cast<aes_key_t*>(calloc( 1, sizeof(*key)));
   assert(!posix_memalign((void **) &key->key, 4096, AES_KEY_MAX_LEN));
 
   our_madvise(key->key, AES_KEY_MAX_LEN, MADV_DONTDUMP);