Skip to content

fixed a bug with bool type mapping in vkext#1304

Merged
Danil42Russia merged 1 commit intomasterfrom
danil42russia/fix_bool_mapping_in_vkext
May 13, 2025
Merged

fixed a bug with bool type mapping in vkext#1304
Danil42Russia merged 1 commit intomasterfrom
danil42russia/fix_bool_mapping_in_vkext

Conversation

@Danil42Russia
Copy link
Contributor

@Danil42Russia Danil42Russia commented May 6, 2025

Fixed a bug where tlgen and tl2php converted the bool type as boolean and left vkext as is

{"Bool", PhpTypeName{"boolean", php_field_type::t_bool}},

@Danil42Russia Danil42Russia self-assigned this May 6, 2025
@Danil42Russia Danil42Russia added the bug Something isn't working label May 6, 2025
@Danil42Russia Danil42Russia marked this pull request as ready for review May 7, 2025 15:33
@Danil42Russia Danil42Russia requested a review from DrDet May 7, 2025 15:33
@Danil42Russia Danil42Russia added this to the next milestone May 11, 2025
Copy link
Contributor

@DrDet DrDet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Danil42Russia Danil42Russia merged commit a43df97 into master May 13, 2025
6 checks passed
@Danil42Russia Danil42Russia deleted the danil42russia/fix_bool_mapping_in_vkext branch May 13, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants