use ActionUpdateThread.BGT in actions to fix IDE errors (#65)

vldF · web-flow · commit 46503ac43bab · 2025-07-28T14:36:05.000+03:00
* set all actions update thread to the BGT

* make `getActionUpdateThread` one-line function

* Add TODO to UsagesBaseFinder
diff --git a/src/main/kotlin/com/vk/modulite/actions/NewModuliteAction.kt b/src/main/kotlin/com/vk/modulite/actions/NewModuliteAction.kt
@@ -1,6 +1,7 @@
 package com.vk.modulite.actions
 
 import com.intellij.icons.AllIcons
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
@@ -16,4 +17,6 @@ class NewModuliteAction : AnAction(
         val folder = e.getData(CommonDataKeys.VIRTUAL_FILE) ?: return
         ModuliteBuilder(project).startBuild(folder, fromSource = false)
     }
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 }
diff --git a/src/main/kotlin/com/vk/modulite/actions/NewModuliteFromFolderAction.kt b/src/main/kotlin/com/vk/modulite/actions/NewModuliteFromFolderAction.kt
@@ -1,6 +1,7 @@
 package com.vk.modulite.actions
 
 import com.intellij.icons.AllIcons
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
@@ -35,4 +36,6 @@ class NewModuliteFromFolderAction : AnAction(
             return
         }
     }
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 }
diff --git a/src/main/kotlin/com/vk/modulite/actions/RegenerateModuleRequiresAction.kt b/src/main/kotlin/com/vk/modulite/actions/RegenerateModuleRequiresAction.kt
@@ -1,5 +1,6 @@
 package com.vk.modulite.actions
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
@@ -17,7 +18,8 @@ class RegenerateModuleRequiresAction : AnAction() {
         val file = e.getData(CommonDataKeys.VIRTUAL_FILE)
         if (file == null || file.name != ".modulite.yaml") {
             e.presentation.isEnabledAndVisible = false
-            return
         }
     }
+
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
 }
diff --git a/src/main/kotlin/com/vk/modulite/actions/SelectionBasedPsiElementAction.kt b/src/main/kotlin/com/vk/modulite/actions/SelectionBasedPsiElementAction.kt
@@ -1,6 +1,7 @@
 package com.vk.modulite.actions
 
 import com.intellij.codeInsight.hint.HintManager
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnAction
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
@@ -105,6 +106,8 @@ abstract class SelectionBasedPsiElementAction<T : PsiElement>(
         return PsiTreeUtil.findElementOfClassAtRange(file, selectionStart, selectionEnd, myClass)
     }
 
+    override fun getActionUpdateThread() = ActionUpdateThread.BGT
+
     companion object {
         private fun getEditor(e: AnActionEvent) = e.getData(CommonDataKeys.EDITOR)
         private fun getPsiFile(e: AnActionEvent) = e.getData(CommonDataKeys.PSI_FILE)
diff --git a/src/main/kotlin/com/vk/modulite/actions/usages/base/UsagesBaseFinder.kt b/src/main/kotlin/com/vk/modulite/actions/usages/base/UsagesBaseFinder.kt
@@ -60,6 +60,7 @@ abstract class UsagesBaseFinder {
             it is DefaultSearchScopeProviders.CustomNamed
         } ?: return
 
+        // TODO: remove `allowSlowOperations`
         val scopes = SlowOperations.allowSlowOperations<List<SearchScope>, RuntimeException> {
             provider.getSearchScopes(
                 element.project,
diff --git a/src/main/kotlin/com/vk/modulite/actions/usages/php/FindSymbolUsagesInCurrentModuleAction.kt b/src/main/kotlin/com/vk/modulite/actions/usages/php/FindSymbolUsagesInCurrentModuleAction.kt
@@ -2,11 +2,9 @@ package com.vk.modulite.actions.usages.php
 
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
-import com.intellij.util.SlowOperations
 import com.jetbrains.php.lang.psi.elements.PhpPsiElement
 import com.jetbrains.php.lang.psi.elements.Variable
 import com.vk.modulite.actions.PhpPsiElementAction
-import com.vk.modulite.modulite.Modulite
 import com.vk.modulite.psi.extensions.files.containingModulite
 
 class FindSymbolUsagesInCurrentModuleAction : PhpPsiElementAction<PhpPsiElement>(PhpPsiElement::class.java) {
@@ -20,9 +18,7 @@ class FindSymbolUsagesInCurrentModuleAction : PhpPsiElementAction<PhpPsiElement>
             return
         }
 
-        val modulite = SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
-            e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
-        }
+        val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
 
         if (modulite == null) {
             e.presentation.isEnabledAndVisible = false
diff --git a/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindAllowedSymbolUsagesInModuleAction.kt b/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindAllowedSymbolUsagesInModuleAction.kt
@@ -1,5 +1,6 @@
 package com.vk.modulite.actions.usages.yaml
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
 import com.intellij.util.SlowOperations
@@ -19,9 +20,7 @@ class FindAllowedSymbolUsagesInModuleAction : YamlPsiElementAction<YAMLQuotedTex
     }
 
     override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
-        val modulite = SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
-            e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
-        }
+        val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
 
         if (element == null || modulite == null) {
             e.presentation.isEnabledAndVisible = false
diff --git a/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindModuleUsagesInCurrentModuleAction.kt b/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindModuleUsagesInCurrentModuleAction.kt
@@ -1,5 +1,6 @@
 package com.vk.modulite.actions.usages.yaml
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
 import com.intellij.psi.PsiElement
@@ -40,10 +41,7 @@ class FindModuleUsagesInCurrentModuleAction : YamlPsiElementAction<YAMLQuotedTex
     }
 
     override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
-        val module =
-            SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
-                e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
-            }
+        val module = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
 
         if (element == null || module == null) {
             e.presentation.isEnabledAndVisible = false
diff --git a/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindSymbolUsagesInCurrentModuleAction.kt b/src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindSymbolUsagesInCurrentModuleAction.kt
@@ -1,5 +1,6 @@
 package com.vk.modulite.actions.usages.yaml
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.openapi.actionSystem.CommonDataKeys
 import com.intellij.util.SlowOperations
@@ -15,10 +16,7 @@ class FindSymbolUsagesInCurrentModuleAction : YamlPsiElementAction<YAMLQuotedTex
     }
 
     override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
-        val modulite =
-            SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
-                e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
-            }
+        val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
 
         if (element == null || modulite == null) {
             e.presentation.isEnabledAndVisible = false

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package com.vk.modulite.actions`
`2`	`2`
`3`	`3`	`import com.intellij.icons.AllIcons`
	`4`	`+import com.intellij.openapi.actionSystem.ActionUpdateThread`
`4`	`5`	`import com.intellij.openapi.actionSystem.AnAction`
`5`	`6`	`import com.intellij.openapi.actionSystem.AnActionEvent`
`6`	`7`	`import com.intellij.openapi.actionSystem.CommonDataKeys`
`@@ -16,4 +17,6 @@ class NewModuliteAction : AnAction(`
`16`	`17`	`val folder = e.getData(CommonDataKeys.VIRTUAL_FILE) ?: return`
`17`	`18`	`ModuliteBuilder(project).startBuild(folder, fromSource = false)`
`18`	`19`	`}`
	`20`	`+`
	`21`	`+ override fun getActionUpdateThread() = ActionUpdateThread.BGT`
`19`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`package com.vk.modulite.actions`
`2`	`2`
	`3`	`+import com.intellij.openapi.actionSystem.ActionUpdateThread`
`3`	`4`	`import com.intellij.openapi.actionSystem.AnAction`
`4`	`5`	`import com.intellij.openapi.actionSystem.AnActionEvent`
`5`	`6`	`import com.intellij.openapi.actionSystem.CommonDataKeys`
`@@ -17,7 +18,8 @@ class RegenerateModuleRequiresAction : AnAction() {`
`17`	`18`	`val file = e.getData(CommonDataKeys.VIRTUAL_FILE)`
`18`	`19`	`if (file == null \|\| file.name != ".modulite.yaml") {`
`19`	`20`	`e.presentation.isEnabledAndVisible = false`
`20`		`- return`
`21`	`21`	`}`
`22`	`22`	`}`
	`23`	`+`
	`24`	`+ override fun getActionUpdateThread() = ActionUpdateThread.BGT`
`23`	`25`	`}`