new rule about absence of the declare section, test, updated .gitignore

Author: Hidanio

.gitignore

@@ -6,3 +6,4 @@ src/cmd/stubs/phpstorm-stubs/
 y.output
 .idea
 vendor
+src/tests/golden/testdata/quickfix/*.fix

src/linter/block.go

@@ -378,6 +378,7 @@ func (b *blockWalker) EnterNode(n ir.Node) (res bool) {
 		for _, st := range s.Stmts {
 			b.addStatement(st)
 		}
+		b.handleDeclareSection(s)
 	case *ir.StmtList:
 		for _, st := range s.Stmts {
 			b.addStatement(st)
@@ -551,6 +552,23 @@ func (b *blockWalker) handleAndCheckGlobalStmt(s *ir.GlobalStmt) {
 	}
 }
 
+func (b *blockWalker) handleDeclareSection(root *ir.Root) {
+	isExist := false
+
+	for _, stmt := range root.Stmts {
+		_, ok := stmt.(*ir.DeclareStmt)
+		if ok {
+			isExist = true
+			break
+		}
+	}
+
+	if !isExist {
+		b.report(root, LevelWarning, "noDeclareSection", "Missed declare(strict_types = 1) directive")
+		b.r.addQuickFix("noDeclareSection", b.linter.quickfix.CreateDeclareStrictTypes(root))
+	}
+}
+
 func (b *blockWalker) handleFunction(fun *ir.FunctionStmt) bool {
 	if b.ignoreFunctionBodies {
 		return false

src/linter/quickfix.go

@@ -47,6 +47,14 @@ func (g *QuickFixGenerator) NullForNotNullableProperty(prop *ir.PropertyStmt) qu
 	}
 }
 
+func (g *QuickFixGenerator) CreateDeclareStrictTypes(root *ir.Root) quickfix.TextEdit {
+	return quickfix.TextEdit{
+		StartPos:    root.Position.StartPos,
+		EndPos:      root.Position.StartPos,
+		Replacement: "declare(strict_types = 1);\n",
+	}
+}
+
 func (g *QuickFixGenerator) GetType(node ir.Node, isFunctionName, nodeText string, isNegative bool) quickfix.TextEdit {
 	pos := ir.GetPosition(node)
 

src/linter/report.go

@@ -25,6 +25,15 @@ func addBuiltinCheckers(reg *CheckersRegistry) {
 			After:    `$s = strip_tags($s, '<br>')`,
 		},
 
+		{
+			Name:     "noDeclareSection",
+			Default:  true,
+			Quickfix: true,
+			Comment:  "Report declare(strict_types=1) has not been set.",
+			Before:   ` `,
+			After:    `declare(strict_types = 1);`,
+		},
+
 		{
 			Name:     "emptyStmt",
 			Default:  true,

src/tests/golden/testdata/quickfix/noDeclareSection.php

@@ -0,0 +1,4 @@
+<?php
+function test(): string {
+  return "test";
+}

src/tests/golden/testdata/quickfix/noDeclareSection.php.fix.expected

@@ -0,0 +1,5 @@
+<?php
+declare(strict_types = 1);
+function test(): string {
+    return "test";
+}