refactor: migrate problem authors/curators/testers to ProblemRole

Author: whlongg

<desired bridge log path>

@@ -1,5 +1,3 @@
-from operator import attrgetter
-
 from django import forms
 from django.contrib import admin
 from django.db import transaction
@@ -10,7 +8,8 @@
 from django.utils.translation import gettext, gettext_lazy as _, ngettext
 from reversion.admin import VersionAdmin
 
-from judge.models import LanguageLimit, Problem, ProblemClarification, ProblemTranslation, Profile, Solution
+from judge.models import LanguageLimit, Problem, ProblemClarification, ProblemTranslation, Solution
+from judge.models.role import ProblemRole, ROLE_AUTHOR
 from judge.utils.views import NoBatchDeleteMixin
 from judge.widgets import AdminHeavySelect2MultipleWidget, AdminHeavySelect2Widget, AdminMartorWidget, \
     AdminSelect2MultipleWidget, AdminSelect2Widget, CheckboxSelectMultipleWithSelectAll
@@ -21,21 +20,15 @@ class ProblemForm(ModelForm):
 
     def __init__(self, *args, **kwargs):
         super(ProblemForm, self).__init__(*args, **kwargs)
-        self.fields['authors'].widget.can_add_related = False
-        self.fields['curators'].widget.can_add_related = False
         self.fields['suggester'].widget.can_add_related = False
-        self.fields['testers'].widget.can_add_related = False
         self.fields['banned_users'].widget.can_add_related = False
         self.fields['change_message'].widget.attrs.update({
             'placeholder': gettext('Describe the changes you made (optional)'),
         })
 
     class Meta:
         widgets = {
-            'authors': AdminHeavySelect2MultipleWidget(data_view='profile_select2'),
-            'curators': AdminHeavySelect2MultipleWidget(data_view='profile_select2'),
             'suggester': AdminHeavySelect2Widget(data_view='profile_select2'),
-            'testers': AdminHeavySelect2MultipleWidget(data_view='profile_select2'),
             'banned_users': AdminHeavySelect2MultipleWidget(data_view='profile_select2'),
             'organization': AdminHeavySelect2Widget(data_view='organization_select2'),
             'types': AdminSelect2MultipleWidget,
@@ -48,13 +41,18 @@ class ProblemCreatorListFilter(admin.SimpleListFilter):
     title = parameter_name = 'creator'
 
     def lookups(self, request, model_admin):
-        queryset = Profile.objects.exclude(authored_problems=None).values_list('user__username', flat=True)
+        queryset = ProblemRole.objects.filter(
+            role=ROLE_AUTHOR,
+        ).values_list('user__user__username', flat=True).distinct()
         return [(name, name) for name in queryset]
 
     def queryset(self, request, queryset):
         if self.value() is None:
             return queryset
-        return queryset.filter(authors__user__username=self.value())
+        return queryset.filter(
+            problem_roles__role=ROLE_AUTHOR,
+            problem_roles__user__user__username=self.value(),
+        )
 
 
 class LanguageLimitInlineForm(ModelForm):
@@ -118,12 +116,26 @@ def has_permission_full_markup(self, request, obj=None):
     has_add_permission = has_change_permission = has_delete_permission = has_permission_full_markup
 
 
+class ProblemRoleInlineForm(ModelForm):
+    class Meta:
+        model = ProblemRole
+        fields = ('user', 'role')
+        widgets = {'user': AdminHeavySelect2Widget(data_view='profile_select2')}
+
+
+class ProblemRoleInline(admin.TabularInline):
+    model = ProblemRole
+    fields = ('user', 'role')
+    extra = 0
+    form = ProblemRoleInlineForm
+
+
 class ProblemAdmin(NoBatchDeleteMixin, VersionAdmin):
     fieldsets = (
         (None, {
             'fields': (
-                'code', 'name', 'suggester', 'is_public', 'is_manually_managed', 'date', 'authors',
-                'curators', 'testers', 'is_organization_private', 'organization', 'submission_source_visibility_mode',
+                'code', 'name', 'suggester', 'is_public', 'is_manually_managed', 'date',
+                'is_organization_private', 'organization', 'submission_source_visibility_mode',
                 'testcase_visibility_mode', 'testcase_result_visibility_mode', 'allow_view_feedback',
                 'is_full_markup', 'pdf_url', 'source', 'description', 'license',
             ),
@@ -138,8 +150,9 @@ class ProblemAdmin(NoBatchDeleteMixin, VersionAdmin):
     )
     list_display = ['code', 'name', 'show_authors', 'points', 'is_public', 'show_public']
     ordering = ['code']
-    search_fields = ('code', 'name', 'authors__user__username', 'curators__user__username')
-    inlines = [LanguageLimitInline, ProblemClarificationInline, ProblemSolutionInline, ProblemTranslationInline]
+    search_fields = ('code', 'name', 'problem_roles__user__user__username')
+    inlines = [ProblemRoleInline, LanguageLimitInline, ProblemClarificationInline,
+               ProblemSolutionInline, ProblemTranslationInline]
     list_max_show_all = 1000
     actions_on_top = True
     actions_on_bottom = True
@@ -173,7 +186,10 @@ def get_readonly_fields(self, request, obj=None):
 
     @admin.display(description=_('authors'))
     def show_authors(self, obj):
-        return ', '.join(map(attrgetter('user.username'), obj.authors.all()))
+        return ', '.join(
+            ProblemRole.objects.filter(problem=obj, role=ROLE_AUTHOR)
+            .values_list('user__user__username', flat=True),
+        )
 
     @admin.display(description='')
     def show_public(self, obj):
@@ -203,7 +219,9 @@ def make_private(self, request, queryset):
                                             count) % count)
 
     def get_queryset(self, request):
-        return Problem.get_editable_problems(request.user).prefetch_related('authors__user').distinct()
+        return Problem.get_editable_problems(request.user).prefetch_related(
+            'problem_roles__user__user',
+        ).distinct()
 
     def has_change_permission(self, request, obj=None):
         if obj is None:
@@ -216,9 +234,7 @@ def formfield_for_manytomany(self, db_field, request=None, **kwargs):
         return super(ProblemAdmin, self).formfield_for_manytomany(db_field, request, **kwargs)
 
     def get_form(self, *args, **kwargs):
-        form = super(ProblemAdmin, self).get_form(*args, **kwargs)
-        form.base_fields['authors'].queryset = Profile.objects.all()
-        return form
+        return super(ProblemAdmin, self).get_form(*args, **kwargs)
 
     def save_model(self, request, obj, form, change):
         super(ProblemAdmin, self).save_model(request, obj, form, change)

judge/admin/problem.py

@@ -5,7 +5,7 @@
 from django.contrib import admin, messages
 from django.core.cache import cache
 from django.core.exceptions import PermissionDenied
-from django.db.models import Q
+from django.db.models import Exists, OuterRef
 from django.http import HttpResponseRedirect
 from django.shortcuts import get_object_or_404
 from django.urls import path, reverse
@@ -17,6 +17,7 @@
 
 from judge.models import ContestParticipation, ContestProblem, ContestSubmission, Profile, Submission, \
     SubmissionSource, SubmissionTestCase
+from judge.models.role import ProblemRole, ROLE_AUTHOR, ROLE_CURATOR
 from judge.utils.raw_sql import use_straight_join
 from judge.widgets import AdminAceWidget
 
@@ -143,8 +144,12 @@ def get_queryset(self, request):
         )
         use_straight_join(queryset)
         if not request.user.has_perm('judge.edit_all_problem'):
-            id = request.profile.id
-            queryset = queryset.filter(Q(problem__authors__id=id) | Q(problem__curators__id=id)).distinct()
+            queryset = queryset.annotate(
+                has_editor=Exists(ProblemRole.objects.filter(
+                    problem_id=OuterRef('problem_id'), user_id=request.profile.id,
+                    role__in=[ROLE_AUTHOR, ROLE_CURATOR],
+                )),
+            ).filter(has_editor=True).distinct()
         return queryset
 
     def has_add_permission(self, request):
@@ -173,8 +178,12 @@ def judge(self, request, queryset):
                               level=messages.ERROR)
             return
         if not request.user.has_perm('judge.edit_all_problem'):
-            id = request.profile.id
-            queryset = queryset.filter(Q(problem__authors__id=id) | Q(problem__curators__id=id))
+            queryset = queryset.annotate(
+                has_editor=Exists(ProblemRole.objects.filter(
+                    problem_id=OuterRef('problem_id'), user_id=request.profile.id,
+                    role__in=[ROLE_AUTHOR, ROLE_CURATOR],
+                )),
+            ).filter(has_editor=True)
         judged = len(queryset)
         for model in queryset:
             model.judge(rejudge=True, batch_rejudge=True, rejudge_user=request.user)

judge/admin/submission.py

@@ -225,17 +225,13 @@ class Meta:
         model = Problem
         fields = ['is_public', 'code', 'name', 'time_limit', 'memory_limit', 'points', 'partial',
                   'statement_file', 'source', 'types', 'group', 'submission_source_visibility_mode',
-                  'testcase_visibility_mode', 'description', 'testers']
+                  'testcase_visibility_mode', 'description']
         widgets = {
             'types': Select2MultipleWidget,
             'group': Select2Widget,
             'submission_source_visibility_mode': Select2Widget,
             'testcase_visibility_mode': Select2Widget,
             'description': MartorWidget(attrs={'data-markdownfy-url': reverse_lazy('problem_preview')}),
-            'testers': HeavySelect2MultipleWidget(
-                data_view='profile_select2',
-                attrs={'style': 'width: 100%'},
-            ),
         }
         help_texts = {
             'is_public': _(

judge/forms.py

@@ -0,0 +1,95 @@
+"""Single migration: create ProblemRole, copy problem authors/curators/testers data, remove old M2M fields."""
+import django.db.models.deletion
+from django.db import migrations, models
+
+ROLE_AUTHOR = 'A'
+ROLE_CURATOR = 'C'
+ROLE_TESTER = 'T'
+
+
+def forwards(apps, schema_editor):
+    Problem = apps.get_model('judge', 'Problem')
+    ProblemRole = apps.get_model('judge', 'ProblemRole')
+
+    problem_roles = []
+    for problem in Problem.objects.prefetch_related('authors', 'curators', 'testers').iterator():
+        for author in problem.authors.all():
+            problem_roles.append(ProblemRole(problem=problem, user=author, role=ROLE_AUTHOR))
+        for curator in problem.curators.all():
+            problem_roles.append(ProblemRole(problem=problem, user=curator, role=ROLE_CURATOR))
+        for tester in problem.testers.all():
+            problem_roles.append(ProblemRole(problem=problem, user=tester, role=ROLE_TESTER))
+    ProblemRole.objects.bulk_create(problem_roles, ignore_conflicts=True)
+
+
+def backwards(apps, schema_editor):
+    Problem = apps.get_model('judge', 'Problem')
+    ProblemRole = apps.get_model('judge', 'ProblemRole')
+
+    for problem in Problem.objects.all().iterator():
+        roles = ProblemRole.objects.filter(problem=problem)
+        problem.authors.set(roles.filter(role=ROLE_AUTHOR).values_list('user', flat=True))
+        problem.curators.set(roles.filter(role=ROLE_CURATOR).values_list('user', flat=True))
+        problem.testers.set(roles.filter(role=ROLE_TESTER).values_list('user', flat=True))
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('judge', '0220_migrate_contest_roles'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='ProblemRole',
+            fields=[
+                (
+                    'id',
+                    models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
+                ),
+                (
+                    'role',
+                    models.CharField(
+                        choices=[('A', 'Author'), ('C', 'Curator'), ('T', 'Tester')],
+                        max_length=1,
+                        verbose_name='role',
+                    ),
+                ),
+                (
+                    'problem',
+                    models.ForeignKey(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name='problem_roles',
+                        to='judge.problem',
+                        verbose_name='problem',
+                    ),
+                ),
+                (
+                    'user',
+                    models.ForeignKey(
+                        on_delete=django.db.models.deletion.CASCADE,
+                        related_name='problem_roles',
+                        to='judge.profile',
+                        verbose_name='user',
+                    ),
+                ),
+            ],
+            options={
+                'verbose_name': 'problem role',
+                'verbose_name_plural': 'problem roles',
+                'unique_together': {('problem', 'user', 'role')},
+            },
+        ),
+        migrations.RunPython(forwards, backwards),
+        migrations.RemoveField(
+            model_name='problem',
+            name='authors',
+        ),
+        migrations.RemoveField(
+            model_name='problem',
+            name='curators',
+        ),
+        migrations.RemoveField(
+            model_name='problem',
+            name='testers',
+        ),
+    ]

judge/migrations/0221_migrate_problem_roles.py

@@ -11,7 +11,7 @@
     problem_directory_file
 from judge.models.profile import Badge, Organization, OrganizationMonthlyUsage, OrganizationRequest, \
     Profile, WebAuthnCredential
-from judge.models.role import ContestRole, ROLE_AUTHOR, ROLE_CURATOR, ROLE_TESTER
+from judge.models.role import ContestRole, ProblemRole, ROLE_AUTHOR, ROLE_CURATOR, ROLE_TESTER
 from judge.models.runtime import Judge, Language, RuntimeVersion
 from judge.models.submission import SUBMISSION_RESULT, Submission, SubmissionSource, SubmissionTestCase
 from judge.models.tag import Tag, TagData, TagGroup, TagProblem
@@ -23,6 +23,7 @@
 revisions.register(Contest, follow=['contest_problems'])
 revisions.register(ContestProblem)
 revisions.register(ContestRole)
+revisions.register(ProblemRole)
 revisions.register(Organization)
 revisions.register(BlogPost)
 revisions.register(Solution)

judge/models/__init__.py

@@ -18,7 +18,7 @@
 from judge import contest_format, event_poster as event
 from judge.models.problem import Problem
 from judge.models.profile import Organization, Profile
-from judge.models.role import ContestRole, ROLE_AUTHOR, ROLE_CURATOR, ROLE_TESTER, RoleQuerySetAdapter
+from judge.models.role import ContestRole, RoleQuerySetAdapter, ROLE_AUTHOR, ROLE_CURATOR, ROLE_TESTER
 from judge.models.submission import Submission
 from judge.ratings import rate_contest
 from judge.utils.unicode import utf8bytes