cargo clippy --fix && cargo fmt --all (#9)

Author: qryxip

onnxruntime-sys/build.rs

@@ -270,15 +270,15 @@ fn extract_archive(filename: &Path, output: &Path) {
 }
 
 fn extract_tgz(filename: &Path, output: &Path) {
-    let file = fs::File::open(&filename).unwrap();
+    let file = fs::File::open(filename).unwrap();
     let buf = io::BufReader::new(file);
     let tar = flate2::read::GzDecoder::new(buf);
     let mut archive = tar::Archive::new(tar);
     archive.unpack(output).unwrap();
 }
 
 fn extract_zip(filename: &Path, outpath: &Path) {
-    let file = fs::File::open(&filename).unwrap();
+    let file = fs::File::open(filename).unwrap();
     let buf = io::BufReader::new(file);
     let mut archive = zip::ZipArchive::new(buf).unwrap();
     for i in 0..archive.len() {
@@ -294,7 +294,7 @@ fn extract_zip(filename: &Path, outpath: &Path) {
             );
             if let Some(p) = outpath.parent() {
                 if !p.exists() {
-                    fs::create_dir_all(&p).unwrap();
+                    fs::create_dir_all(p).unwrap();
                 }
             }
             let mut outfile = fs::File::create(&outpath).unwrap();

onnxruntime-sys/examples/c_api_sample.rs

@@ -289,7 +289,7 @@ fn main() {
     let input_node_names_ptr_ptr: *const *const i8 = input_node_names_ptr.as_ptr();
 
     let output_node_names_cstring: Vec<std::ffi::CString> = output_node_names
-        .into_iter()
+        .iter()
         .map(|n| std::ffi::CString::new(n.clone()).unwrap())
         .collect();
     let output_node_names_ptr: Vec<*const i8> = output_node_names_cstring

onnxruntime/examples/print_structure.rs

@@ -5,8 +5,7 @@ use std::error::Error;
 fn main() -> Result<(), Box<dyn Error>> {
     // provide path to .onnx model on disk
     let path = std::env::args()
-        .skip(1)
-        .next()
+        .nth(1)
         .expect("Must provide an .onnx file as the first arg");
 
     let environment = environment::Environment::builder()

onnxruntime/src/error.rs

@@ -197,13 +197,13 @@ impl From<*const sys::OrtStatus> for OrtStatusWrapper {
 
 pub(crate) fn assert_null_pointer<T>(ptr: *const T, name: &str) -> Result<()> {
     ptr.is_null()
-        .then(|| ())
+        .then_some(())
         .ok_or_else(|| OrtError::PointerShouldBeNull(name.to_owned()))
 }
 
 pub(crate) fn assert_not_null_pointer<T>(ptr: *const T, name: &str) -> Result<()> {
     (!ptr.is_null())
-        .then(|| ())
+        .then_some(())
         .ok_or_else(|| OrtError::PointerShouldBeNull(name.to_owned()))
 }
 

onnxruntime/src/session.rs

@@ -758,7 +758,7 @@ mod dangerous {
         let status = unsafe { f(session_ptr, &mut num_nodes) };
         status_to_result(status).map_err(OrtError::InOutCount)?;
         assert_null_pointer(status, "SessionStatus")?;
-        (num_nodes != 0).then(|| ()).ok_or_else(|| {
+        (num_nodes != 0).then_some(()).ok_or_else(|| {
             OrtError::InOutCount(OrtApiError::Msg("No nodes in model".to_owned()))
         })?;
         Ok(num_nodes)
@@ -862,7 +862,7 @@ mod dangerous {
             unsafe { g_ort().GetTensorElementType.unwrap()(tensor_info_ptr, &mut type_sys) };
         status_to_result(status).map_err(OrtError::TensorElementType)?;
         (type_sys != sys::ONNXTensorElementDataType::ONNX_TENSOR_ELEMENT_DATA_TYPE_UNDEFINED)
-            .then(|| ())
+            .then_some(())
             .ok_or(OrtError::UndefinedTensorElementType)?;
         // This transmute should be safe since its value is read from GetTensorElementType which we must trust.
         let io_type: TensorElementDataType = unsafe { std::mem::transmute(type_sys) };

onnxruntime/src/tensor/ort_owned_tensor.rs

@@ -97,7 +97,7 @@ where
         let status = unsafe { g_ort().IsTensor.unwrap()(self.tensor_ptr, &mut is_tensor) };
         status_to_result(status).map_err(OrtError::IsTensor)?;
         (is_tensor == 1)
-            .then(|| ())
+            .then_some(())
             .ok_or(OrtError::IsTensorCheck)?;
 
         // Get pointer to output tensor float values