added more test

Author: VREMSoftwareDevelopment

app/build.properties

@@ -1,7 +1,7 @@
 #Build Properties
-#Sat Jun 09 08:51:05 EDT 2018
+#Sat Jun 09 13:24:10 EDT 2018
 version_minor=9
-version_build=0
-version_patch=1
+version_build=1
+version_patch=0
 version_store=38
 version_major=1

app/src/main/java/com/vrem/wifianalyzer/wifi/accesspoint/AccessPointDetail.java

@@ -69,10 +69,16 @@ public View makeViewDetailed(@NonNull WiFiDetail wiFiDetail) {
         setViewCompact(view, wiFiDetail, false);
         setViewExtra(view, wiFiDetail);
         setViewVendorLong(view, wiFiDetail.getWiFiAdditional());
+        enableTextSelection(view);
 
         return view;
     }
 
+    private void enableTextSelection(View view) {
+        view.<TextView>findViewById(R.id.ssid).setTextIsSelectable(true);
+        view.<TextView>findViewById(R.id.vendorLong).setTextIsSelectable(true);
+    }
+
     private void setViewCompact(@NonNull View view, @NonNull WiFiDetail wiFiDetail, boolean isChild) {
         Context context = view.getContext();
 

app/src/main/res/layout/access_point_view_compact.xml

@@ -50,7 +50,6 @@
 
             <TextView
                 android:id="@+id/ssid"
-                android:textIsSelectable="true"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:textStyle="bold"/>

app/src/main/res/layout/access_point_view_complete.xml

@@ -60,7 +60,6 @@
 
             <TextView
                 android:id="@+id/ssid"
-                android:textIsSelectable="true"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:textStyle="bold"/>
@@ -100,7 +99,7 @@
                 android:layout_height="wrap_content"
                 android:orientation="vertical">
 
-                <!-- Row 2 -->
+                <!-- Row 1 -->
                 <LinearLayout
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
@@ -140,7 +139,7 @@
                         android:textStyle="bold"/>
                 </LinearLayout>
 
-                <!-- Row 2 optional -->
+                <!-- Row 2 -->
                 <LinearLayout
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
@@ -164,7 +163,6 @@
 
                     <TextView
                         android:id="@+id/vendorShort"
-                        android:textIsSelectable="true"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:visibility="gone"/>

app/src/main/res/layout/access_point_view_popup.xml

@@ -32,7 +32,6 @@
 
         <TextView
             android:id="@+id/vendorLong"
-            android:textIsSelectable="true"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:visibility="gone"/>

app/src/test/java/com/vrem/wifianalyzer/wifi/accesspoint/AccessPointDetailTest.java

@@ -44,8 +44,10 @@
 import java.util.Locale;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
@@ -94,7 +96,7 @@ public void testMakeViewShouldUseGivenView() {
     }
 
     @Test
-    public void testMakeViewFullWithConfiguredImageVisible() {
+    public void testMakeViewCompleteWithConfiguredImageVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, true));
         // execute
@@ -104,7 +106,7 @@ public void testMakeViewFullWithConfiguredImageVisible() {
     }
 
     @Test
-    public void testMakeViewFullWithTabGone() {
+    public void testMakeViewCompleteWithTabGone() {
         // setup
         WiFiAdditional wiFiAdditional = new WiFiAdditional(StringUtils.EMPTY, false);
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, wiFiAdditional);
@@ -115,7 +117,7 @@ public void testMakeViewFullWithTabGone() {
     }
 
     @Test
-    public void testMakeViewFullWithGroupIndicatorGone() {
+    public void testMakeViewCompleteWithGroupIndicatorGone() {
         // setup
         WiFiAdditional wiFiAdditional = new WiFiAdditional(StringUtils.EMPTY, false);
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, wiFiAdditional);
@@ -126,7 +128,7 @@ public void testMakeViewFullWithGroupIndicatorGone() {
     }
 
     @Test
-    public void testMakeViewFullWithVendorShortNotVisible() {
+    public void testMakeViewCompleteWithVendorShortNotVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
         // execute
@@ -137,7 +139,7 @@ public void testMakeViewFullWithVendorShortNotVisible() {
     }
 
     @Test
-    public void testMakeViewFullWithVendorShortVisible() {
+    public void testMakeViewCompleteWithVendorShortVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(VENDOR_NAME, false));
         // execute
@@ -148,7 +150,7 @@ public void testMakeViewFullWithVendorShortVisible() {
     }
 
     @Test
-    public void testMakeViewFullWithVendorShortMaximumSize() {
+    public void testMakeViewCompleteWithVendorShortMaximumSize() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(VENDOR_NAME, false));
         // execute
@@ -158,7 +160,7 @@ public void testMakeViewFullWithVendorShortMaximumSize() {
     }
 
     @Test
-    public void testMakeViewFullWithTabVisible() {
+    public void testMakeViewCompleteWithTabVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(StringUtils.EMPTY, new WiFiAdditional(StringUtils.EMPTY, false));
         // execute
@@ -168,7 +170,7 @@ public void testMakeViewFullWithTabVisible() {
     }
 
     @Test
-    public void testMakeViewFullWithWiFiDetailAndEmptySSID() {
+    public void testMakeViewCompleteWithWiFiDetailAndEmptySSID() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(StringUtils.EMPTY, new WiFiAdditional(StringUtils.EMPTY, false));
         // execute
@@ -178,7 +180,7 @@ public void testMakeViewFullWithWiFiDetailAndEmptySSID() {
     }
 
     @Test
-    public void testMakeViewFullWithWiFiDetail() {
+    public void testMakeViewCompleteWithWiFiDetail() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
         // execute
@@ -187,6 +189,16 @@ public void testMakeViewFullWithWiFiDetail() {
         validateTextViewValuesFullView(actual, wiFiDetail);
     }
 
+    @Test
+    public void testMakeViewCompleteWithTextNotSelectable() {
+        // setup
+        WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
+        // execute
+        View actual = fixture.makeView(null, null, wiFiDetail, false);
+        // validate
+        assertFalse(actual.<TextView>findViewById(R.id.ssid).isTextSelectable());
+    }
+
     @Test
     public void testMakeViewCompactWithTabGone() {
         // setup
@@ -269,6 +281,17 @@ public void testMakeViewCompactDoesNotHaveFullDetails() {
         assertNull(actual.findViewById(R.id.vendorShort));
     }
 
+    @Test
+    public void testMakeViewCompactWithTextNotSelectable() {
+        // setup
+        WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
+        when(settings.getAccessPointView()).thenReturn(AccessPointViewType.COMPACT);
+        // execute
+        View actual = fixture.makeView(null, null, wiFiDetail, false);
+        // validate
+        assertFalse(actual.<TextView>findViewById(R.id.ssid).isTextSelectable());
+    }
+
     @Test
     public void testMakeViewPopupWithWiFiDetail() {
         // setup
@@ -280,7 +303,7 @@ public void testMakeViewPopupWithWiFiDetail() {
     }
 
     @Test
-    public void testMakeViewPopupWithVendorNotVisible() {
+    public void testMakeViewDetailedWithVendorNotVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
         // execute
@@ -291,7 +314,7 @@ public void testMakeViewPopupWithVendorNotVisible() {
     }
 
     @Test
-    public void testMakeViewPopupWithVendorVisible() {
+    public void testMakeViewDetailedWithVendorVisible() {
         // setup
         WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(VENDOR_NAME, false));
         // execute
@@ -301,6 +324,17 @@ public void testMakeViewPopupWithVendorVisible() {
         assertEquals(View.VISIBLE, actual.findViewById(R.id.vendorLong).getVisibility());
     }
 
+    @Test
+    public void testMakeViewDetailedWithTextSelectable() {
+        // setup
+        WiFiDetail wiFiDetail = withWiFiDetail(SSID, new WiFiAdditional(StringUtils.EMPTY, false));
+        // execute
+        View actual = fixture.makeViewDetailed(wiFiDetail);
+        // validate
+        assertTrue(actual.<TextView>findViewById(R.id.ssid).isTextSelectable());
+        assertTrue(actual.<TextView>findViewById(R.id.vendorLong).isTextSelectable());
+    }
+
     private WiFiDetail withWiFiDetail(String SSID, WiFiAdditional wiFiAdditional) {
         return new WiFiDetail(SSID, "BSSID", "capabilities", new WiFiSignal(1, 1, WiFiWidth.MHZ_40, 2), wiFiAdditional);
     }