@@ -127,19 +127,20 @@ def __init__(self, lenData: int, joints: List[Joint], desAngles:
127127 should be removed and code refactored.
128128 """
129129 self .lenData = lenData
130- self .desAngle = desAngles
130+ self .desAngle = desAngles #Depricated
131131 self .joints = joints
132132 self .totCount = [0 for i in range (lenData )]
133133 self .rotDirCurr = [None for i in range (lenData )]
134134 self .current = [None for i in range (lenData )]
135135 self .homing = [None for i in range (lenData )]
136+ #Often used in the form SerialData.currAngle[:-1]
136137 self .currAngle = [0. for i in range (lenData )]
137138 self .prevAngle = [0. for i in range (lenData )]
138139 self .mSpeed = [0. for i in range (lenData )]
139140 self .rotDirDes = [0 for i in range (lenData )]
140- self .dataOut = ['0|0|0 ' for i in range (lenData )]
141- self .maxDeltaAngle = maxDeltaAngle
142- self .angleTol = angleTol
141+ self .dataOut = ['0|0' for i in range (lenData )]
142+ self .maxDeltaAngle = maxDeltaAngle #Depricated
143+ self .angleTol = angleTol #Depricated
143144 self .limBool = [False for i in range (lenData )]
144145
145146 def ExtractVars (self , dataPacket : List [str ]):
@@ -153,7 +154,7 @@ def ExtractVars(self, dataPacket: List[str]):
153154 """
154155 for i in range (self .lenData ):
155156 args = dataPacket [i ].split ('|' )
156- if len (args ) = = 3 :
157+ if len (args ) > = 3 :
157158 self .homing [i ] = args [2 ]
158159 self .homing [i ] = int (self .homing [i ])
159160 if len (args ) == 4 :
@@ -163,7 +164,6 @@ def ExtractVars(self, dataPacket: List[str]):
163164 self .totCount [i ] = int (self .totCount [i ])
164165 self .rotDirCurr [i ] = int (self .rotDirCurr [i ])
165166 self .prevAngle [i ] = self .currAngle [i ]
166- #TODO: CHECK!!!
167167 if i == self .lenData - 1 :
168168 #Gripper doesn't have an 'angle'
169169 self .currAngle [i ] = self .totCount [i ]
@@ -194,6 +194,7 @@ def ExtractVars(self, dataPacket: List[str]):
194194
195195 def Dtheta2Mspeed (self , dtheta : "np.ndarray[float]" ,
196196 dthetaMax : List [float ], PWMMin : int , PWMMax : int ):
197+ #DEPRICATED!
197198 """Translates desired motor velocities in rad/s to PWM.
198199 :param dtheta: Numpy array of motor velocities in [rad/s].
199200 :param dthetaMax: Angular velocity of each motor at a PWM of 255.
@@ -208,6 +209,7 @@ def Dtheta2Mspeed(self, dtheta: "np.ndarray[float]",
208209 for i in range (self .lenData - 1 )] #Rudimentary solution, PID will help!
209210
210211 def CheckCommFault (self ) -> bool :
212+ #DEPRICATED
211213 """Checks if data got corrupted using a maximum achievable
212214 change in angle between two timesteps.
213215 :return commFault: Boolean indicating if new angle is
@@ -229,6 +231,7 @@ def CheckCommFault(self) -> bool:
229231 return commFault
230232
231233 def CheckTolAng (self ) -> bool :
234+ #DEPRICATED
232235 """Determines if the desired angle has been reached within the
233236 given tolerance, and if the desired angle is reachable.
234237 If the desired angle is unreachable, the closest angle is chosen.
@@ -267,6 +270,7 @@ def CheckJointLim(self):
267270
268271
269272 def GetDir (self ):
273+ #DEPRICATED
270274 """Gives the desired direction of rotation.
271275 """
272276 for i in range (self .lenData ):
@@ -279,7 +283,8 @@ def GetDir(self):
279283 self .rotDirDes [i ] = self .rotDirCurr [i ]
280284
281285 def PControl1 (self , i : int , mSpeedMax : int , mSpeedMin : int ):
282- """Gives motor speed commands proportional to the angle error.
286+ #DEPRICATED
287+ """Gives motor speed commands propor tional to the angle error.
283288 :param i: Current iteration number.
284289 :param mSpeedMax: Maximum rotational speed,
285290 portrayed in PWM [0, 255].
0 commit comments