removed range check error on zero sized range removal within valid index range

Author: sglienke

Source/Base/Collections/Spring.Collections.Lists.pas

@@ -920,7 +920,7 @@ procedure TAbstractArrayList<T>.DeleteRange(index, count: Integer);
   tailCount: Integer;
 begin
 {$IFDEF SPRING_ENABLE_GUARD}
-  Guard.CheckRange((index >= 0) and (index < Self.Count), 'index');
+  Guard.CheckRange(index >= 0, 'index');
   Guard.CheckRange((count >= 0) and (count <= Self.Count - index), 'count');
 {$ENDIF}
 

Tests/Source/Base/Spring.Tests.Collections.pas

@@ -182,6 +182,8 @@   TTestIntegerList = class(TTestCase)
     procedure TestExtractRange;
 
     procedure TestTryMethodsReturnDefaultWhenFalse;
+
+    procedure TestDeleteRangeEmptyList;
   end;
 
   TTestStringList = class(TTestCase)
@@ -1124,6 +1126,21 @@ procedure TTestIntegerList.TestCopyTo;
   CheckNotEquals(SUT.First, values[0]);
 end;
 
+procedure TTestIntegerList.TestDeleteRangeEmptyList;
+begin
+  SUT.DeleteRange(0, 0);
+  CheckException(EArgumentOutOfRangeException,
+    procedure
+    begin
+      SUT.DeleteRange(0, 1);
+    end);
+  CheckException(EArgumentOutOfRangeException,
+    procedure
+    begin
+      SUT.DeleteRange(1, 0);
+    end);
+end;
+
 procedure TTestIntegerList.TestEnumeratorMoveNext_VersionMismatch;
 var
   e: IEnumerator<Integer>;