optimized use of Result

Author: sglienke

Source/Base/Collections/Spring.Collections.Base.pas

@@ -3262,22 +3262,26 @@ function TIteratorBlock<T>.MoveNextIndexed: Boolean;
 
 function TIteratorBlock<T>.MoveNextOrdered: Boolean;
 begin
-  Result := Index < Count;
-  if Result then
+  if Index < Count then
   begin
     Current := Items[Index];
     Inc(Index);
-  end;
+    Result := True;
+  end
+  else
+    Result := False;
 end;
 
 function TIteratorBlock<T>.MoveNextReversed: Boolean;
 begin
-  Result := Count > 0;
-  if Result then
+  if Count > 0 then
   begin
     Dec(Count);
     Current := Items[Count];
-  end;
+    Result := True;
+  end
+  else
+    Result := False;
 end;
 
 function TIteratorBlock<T>.MoveNextSkipWhile: Boolean;

Source/Base/Collections/Spring.Collections.Extensions.pas

@@ -1781,7 +1781,10 @@ function TSelectIterator<TSource, TResult>.TryGetElementAt(var value: TResult;
 begin
   Result := fSource.TryGetElementAt(sourceValue, index);
   if Result then
+  begin
     value := fSelector(sourceValue);
+    Result := True;
+  end;
 end;
 
 function TSelectIterator<TSource, TResult>.TryGetFirst(var value: TResult): Boolean;
@@ -1790,7 +1793,10 @@ function TSelectIterator<TSource, TResult>.TryGetFirst(var value: TResult): Bool
 begin
   Result := fSource.TryGetFirst(sourceValue);
   if Result then
+  begin
     value := fSelector(sourceValue);
+    Result := True;
+  end;
 end;
 
 function TSelectIterator<TSource, TResult>.TryGetLast(var value: TResult): Boolean;
@@ -1799,14 +1805,20 @@ function TSelectIterator<TSource, TResult>.TryGetLast(var value: TResult): Boole
 begin
   Result := fSource.TryGetLast(sourceValue);
   if Result then
+  begin
     value := fSelector(sourceValue);
+    Result := True;
+  end;
 end;
 
 function TSelectIterator<TSource, TResult>.TryMoveNext(var current: TResult): Boolean;
 begin
   Result := fEnumerator.MoveNext;
   if Result then
+  begin
     current := fSelector(fEnumerator.Current);
+    Result := True;
+  end;
 end;
 
 procedure TSelectIterator<TSource, TResult>.Start;