fixed defect in Equals method that takes an array

Author: sglienke

Source/Base/Collections/Spring.Collections.Base.pas

@@ -989,13 +989,13 @@ function TEnumerableBase<T>.EqualsTo(const values: array of T): Boolean;
   i := 0;
   enumerator := IEnumerable<T>(this).GetEnumerator;
   comparer := IEqualityComparer<T>(_LookupVtableInfo(giEqualityComparer, GetElementType, SizeOf(T)));
-  while enumerator.MoveNext and (i < Length(values)) do
+  while enumerator.MoveNext do
   begin
-    if not comparer.Equals(enumerator.Current, values[i]) then
-      Break;
+    if (i > High(values)) or not comparer.Equals(enumerator.Current, values[i]) then
+      Exit(False);
     Inc(i);
   end;
-  Result := i = Length(values);
+  Result := i > High(values);
 end;
 
 function TEnumerableBase<T>.EqualsTo(const values: IEnumerable<T>): Boolean;

Tests/Source/Base/Spring.Tests.Collections.pas

@@ -184,6 +184,9 @@   TTestIntegerList = class(TTestCase)
     procedure TestTryMethodsReturnDefaultWhenFalse;
 
     procedure TestDeleteRangeEmptyList;
+
+    procedure EqualsToArray;
+    procedure EqualsToEnumerable;
   end;
 
   TTestStringList = class(TTestCase)
@@ -1068,6 +1071,22 @@ procedure TTestNormalHashSet.TestSetEqualsList;
 
 {$REGION 'TTestIntegerList'}
 
+procedure TTestIntegerList.EqualsToArray;
+begin
+  SimpleFillList;
+  CheckFalse(SUT.EqualsTo([1, 2]));
+  CheckTrue(SUT.EqualsTo([1, 2, 3]));
+  CheckFalse(SUT.EqualsTo([1, 2, 3, 4]));
+end;
+
+procedure TTestIntegerList.EqualsToEnumerable;
+begin
+  SimpleFillList;
+  CheckFalse(SUT.EqualsTo(TEnumerable.From<Integer>([1, 2])));
+  CheckTrue(SUT.EqualsTo(TEnumerable.From<Integer>([1, 2, 3])));
+  CheckFalse(SUT.EqualsTo(TEnumerable.From<Integer>([1, 2, 3, 4])));
+end;
+
 procedure TTestIntegerList.GetCapacity;
 begin
   SimpleFillList;